GNOME Bugzilla – Bug 357180
[libs] gst_controller_new* functions don't increase refcount if needed
Last modified: 2006-10-11 09:13:59 UTC
In gstreamer/libs/gst/controller/gstcontroller.c, if the functions gst_controller_new_list, gst_controller_new_valist (and therefor gst_controller_new) return an existing instance, the reference count is not increased.
2006-09-22 Stefan Kost <firstname.lastname@example.org>
* libs/gst/controller/gstcontroller.c: (gst_controller_new_valist),
Ref instances when returning them again (fixes #357180)
This was fixed incorrectly and corrected by Tim (see bug #357617 for changelog entry), but only for gst_controller_new_valist. gst_controller_new_list is right below that, with almost identical code that is still broken. Patch follows that copies over Tim's changes over to the other function, too.
Created attachment 74463 [details] [review]
Also fix gst_controller_new_list correctly
Thanks, committed with test:
2006-10-11 Tim-Philipp Müller <tim at centricular dot net>
* libs/gst/controller/gstcontroller.c: (gst_controller_new_list):
Fix refcounting here too, just like we did for _new_valist() a few
days ago (#357180) (thanks to René Stadler). Also remove all those
'Since: 0.9' from the gtk-doc blobs.
* tests/check/libs/controller.c: (controller_refcount_new_list),
Unit test for the above.