GNOME Bugzilla – Bug 355984
Atom podcast support
Last modified: 2008-01-07 12:08:06 UTC
Currently only RSS podcast feeds are supported; there are some which use Atom.
* http://planet.lugradio.org/hashlugradio/releases/episodes/feed/atom/ (Atom 0.3)
* http://ccmixter.org/media/feed/atom/audio (Atom 1.0)
Created attachment 72796 [details] [review]
Atom support using the current feed parsing system
This hacks Atom support into the current SAX parser. It's not been thoroughly tested; it might well not support every Atom feed out there.
An alternative approach is to fix bug #323057.
(In reply to comment #1)
> An alternative approach is to fix bug #323057.
I think podcasting could/may be will become pluginised before rewriting the parsing engine. Jonathan Matthew did say something about redoing that, but it may happen later (there maybe a bug about it somewhere too).
Created attachment 72818 [details] [review]
Atom support, removed timezone parsing.
It seems that trying to parse the timezone of an Atom feed with GNU strptime's '%z' is pointless, because:
1. It breaks dates that end in 'Z', which is valid for UTC times.
2. strptime ignores it anyway, and doesn't change the tm struct.
Not sure if this issue with Atom podcasts is already addressed, but it should be noted that Atom podcast episodes can have multiple enclosures. (This allows for things like haveing a podcast in multiple formats all within the same feed)
Since people fix things because they want it to work I thought I'd add some motivation here. Google reader allows you to subscribe to any of your folders or labels as an atom feed. So from your gazillion podcasts, you can browse in Reader and label the individual episodes you actually want to listen to as "ipod" or "listen" or whatever. Then have RB subscribe to that one atom feed and drag it over to your ipod.
How cool would that be?
Yeah, yeah, I know. Go learn C. Just thought I'd try.
*** Bug 438538 has been marked as a duplicate of this bug. ***
*** Bug 438650 has been marked as a duplicate of this bug. ***
(In reply to comment #0)
> Currently only RSS podcast feeds are supported; there are some which use Atom.
> Test feeds:
> * http://planet.lugradio.org/hashlugradio/releases/episodes/feed/atom/ (Atom
> * http://ccmixter.org/media/feed/atom/audio (Atom 1.0)
the CCmixter one doesn't work anymore. Both seem to be parsed correctly by Totem's playlist parser.
(In reply to comment #8)
> (In reply to comment #0)
> > Currently only RSS podcast feeds are supported; there are some which use Atom.
> > Test feeds:
> > * http://planet.lugradio.org/hashlugradio/releases/episodes/feed/atom/ (Atom
> > 0.3)
> > * http://ccmixter.org/media/feed/atom/audio (Atom 1.0)
> the CCmixter one doesn't work anymore. Both seem to be parsed correctly by
> Totem's playlist parser.
Never mind, working again :)
The patch in bug 484768 should fix it.
2007-12-03 Bastien Nocera <firstname.lastname@example.org>
* configure.ac: Require totem-pl-parser 2.21.4
* lib/rb-file-helpers.c: (rb_uri_could_be_podcast):
* lib/rb-file-helpers.h: Add helper function to detect
whether it could be a podcast from the URI passed
* data/rhythmbox.schemas: Handle feed://, itpc:// and itms:// URIs
* podcast/rb-podcast-parse.c: (playlist_metadata_foreach),
(playlist_started), (playlist_ended), (entry_metadata_foreach),
* podcast/rb-podcast-parse.h: Use totem-pl-parser to parse Podcast
files (including Atom files) (Closes: #355984), as well as OPML files
* shell/rb-playlist-manager.c: (handle_playlist_entry_cb),
* shell/rb-shell-player.c: (rb_shell_player_class_init),
* shell/rb-shell.c: (handle_playlist_entry_cb),
(rb_shell_load_uri): Update API to totem-pl-parser 2.21.4, detect
podcasts and OPML files (Closes: #489520) and add them to the
* podcast/test-podcast-parse.c: (main): Call setlocale
so we print UTF-8 characters
Created attachment 102119 [details] [review]
Adds backwards compatibility for usage of totem-plparser.
This patch will add some backwards compatibility to rhythmbox when it comes to using totem-plparser. This version compiles with at least 2.20.0, but is quite likely that it will compile with even earlier version. I just wasn't able to test it out.
That's the easy part. The hard part is that totem-plparser < 2.21.0 did not do podcast parsing.
I removed backwards compatibility because it would require backporting a lot of code from totem-pl-parser 2.21.X to totem 2.20 (for the podcast support), as well as making the rhythmbox code unreadable.
Furthermore, the patch attached just won't work as signals within the library have changed.