GNOME Bugzilla – Bug 355642
gossip_account_set_enabled never used and gossip_account_set_type not implemented
Last modified: 2006-09-13 15:12:42 UTC
gossip_account_set_enabled() should be removed because it's never used in gossip and it crash if we call it because the "enabled" property no longer exists. gossip_account_set_type() is declared in the gossip-account.h but not implemented in the corresponding .c file. The private function account_set_type() should be renamed gossip_account_set_type() and should also run g_object_notify (G_OBJECT (account), "type");
Created attachment 72641 [details] [review] proposed patch
The _set_type() wasn't public purely because changing the type has serious implications on the data in GossipAccount. So you could only set it with gossip_account_new(). With the current Jabber only model, it doesn't make sence to be able to just change the type when you like, and I don't think it makes sense with GossipAccount at all. You should only need to set the type when creating the objct. I see no other use for it otherwise. Changing the type will mean (with Telepathy) that we will have to remove ALL key pair values that are not essential (essential being name, auto_connect, etc) to GossipAccount. This patch needs more work and I would include it with the GDataList update for GossipAccount that we will merge back to HEAD. Also, no changes to GossipAccount will be committed until after this weekend's release, after which we will start using GTK+ 2.10 in HEAD.
Ok. So I just remove the declaration of gossip_account_set_type() from the header and I keep it private and the notify on the property is useless. I make that changes in my patch for the telepathy branch and it will be merged in head later. Thanks.
*** This bug has been marked as a duplicate of 355797 ***