GNOME Bugzilla – Bug 355417
Timeline slider not restricted.
Last modified: 2010-06-11 21:30:20 UTC
Forwarding from https://launchpad.net/distros/ubuntu/+source/f-spot/+bug/59881 """ im using the f-spot that comes with edgy the timeline slider can be slid all the way to the edge of the screen, no matter how big or where the window is. obviously the timeline slider needs to be restricted to the actual timeline. """ From what I can see, the slider allows dragging out of window, onto my 2nd monitor. However the photo display just goes to the end of the photos, rather than displaying none, and so it is mainly a visual annoyance rather than a problem Other information:
Is this still true? The slider can be dragged out, but it directly jumps back to the end of actual timeline when you release it.
Yes, still happens, with the same behaviour as you said. It does appear to be solely a visual bug.
Created attachment 150209 [details] [review] Patch to resolve Bug355417 This bug has been marked as an Ubuntu Paper Cut for Lucid, I have investigated the cause and believe this patch resolves the issue, well for me anyway :) The patch modifies the GroupSelector.cs files UpdateDrag base method to prevent the dragging from going beyond the edges of the timeline.. I am still quite new at this so please forgive any mistakes.. Keep up the good work on this great App Regards Iain Churcher
Created attachment 150500 [details] [review] Updated bug fix for Bug355417 Reworked the above patch to allow automatic scrolling when the selector reaches the edges of the timeline. Also fixed original patch as it only worked when there was no scrolling timeline. I hope that this fully resolves the issue now, it certainly looks alot better than it did before.. Comments welcome.. Regards Iain Churcher
Created attachment 150917 [details] [review] Limits the timeline selector and auto scrolls the timeline Hi, I let a friend do some testing who noticed that the if you moved the mouse to fast the selector would stop where it was rather than the edge of the timeline. Version 3 of this patch now ensures that when the mouse has gone past the endstop the selector is moved to the edge rather than just stopped. Hopefully this is all in order now and has been tested by a few people... Comments Welcome Iain Churcher
Review of attachment 150917 [details] [review]: patch needs more work, as introduces two new bugs: on single click the old slider isn't deleted, and on dragging icon view is not updated
Created attachment 151073 [details] [review] Limit TimeSlider patch version 4 Hi Maxxter, Thanks for taking the time to review this patch, I have fixed the above new comments and the attached patch now correctly updates the icon view at the end of the drag.. and the old slider is removed when clicking. I had to modify the MainWindow.cs file as a direct call from there to 'SetPosition' was the root cause of the issues. Please let me know if you find anything else that needs attention. Thanks again for reviewing this patch Regards Iain Churcher
Created attachment 151678 [details] [review] Fixed whitespace (I guess) I had some issues applying the patch to a clean 0.6.1.5 codebase, I think it was a whitespace issue... Here is the new diff... Could you please check if this is ok?
Hi Pascal de Bruijn... I attempted to apply the new patch to the git head and it didn't apply (MainWindow.cs) ... Do patches have to apply to head? or the last baseline? Cheers Iain Churcher
Let's work on getting this into master. Does this stuff introduce any known issues?
Hi Ruben, I haven't looked at this code for quite a while :) I have just pulled the latest git version 0.7.0. and applied my version of the patch attached below "Limit TimeSlider patch version 4" The patch applied cleanly and re-compiled without errors :) I have given it a quick test and it appears to still be working... As far as I know there are no outstanding issues with this patch and can be committed. If you have any further questions/comments I will be happy to address... Keep up the good work Regards Iain Churcher
Tested this and it worked. I merged this but have done quite a lot of code style cleanups. Please try to follow the code style of F-Spot (though I have to admit the codebase currently isn't always consistent, working on that). Thanks a lot! commit 04ae7f2725236f53f88838cdcfc27aa798f75e00 Author: Iain Churcher <iain.linux.coding@googlemail.com> Date: Fri Jun 11 23:12:24 2010 +0200 Restrict timeline slider. This makes sure that the glass stays in the window. https://bugzilla.gnome.org/show_bug.cgi?id=355417