After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355257 - F-spot Icons
F-spot Icons
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-10 10:33 UTC by Michael Monreal
Modified: 2007-07-30 08:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16



Description Michael Monreal 2006-09-10 10:33:54 UTC
There's a few things to do about f-spot's icons:

1.) Install application icon to hicolor/$size/apps. 
For this, we need the F-spot icon in the following sizes:
- 16x16
- 22x22 / 24x24
- 32x32
- scalable svg
The current icon is installed to $prefix/share/pixmaps/ and is only 48x48 pixels.

2.) Toolbar icons:
- Rotate icons should be updated to match the gimp's blue rotate icons.
- Fullscreen icon could use a themed icon

3.) Emblems:
Update using tango guidelines, keep in sync with gnome (which needs those emblems updated as well)
Comment 1 Bengt Thuree 2006-09-26 11:50:25 UTC
Best if we could use stock icons/emblems, so they are nicely themable
Comment 2 Luca Ferretti 2006-09-26 16:37:00 UTC
Please note that rotate icons are in Icon Naming Utilis from version 0.8 as object-rotate-lef and object-rotate-right. See http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#changelog

Here is yet a bug agains gnome-icon-theme to add those icons
Comment 3 Michael Monreal 2007-04-10 23:08:56 UTC
Most of this bug is actually done now... the remaining stuff:

- Emblems (which is strange, as f-spot/icons/f-spot-events.png is not used here?)
- File->Send mail icon (donno where this is pulled from)
- View->Slideshow and View->Fullscreen: need 16x16 versions
- Help->About: this should be changed to use the GTK_ABOUT stock icon (which will be Tango as soon as the Tango icons land in GTK...
Comment 4 Stephane Delcroix 2007-07-28 07:13:21 UTC
f-spot now uses new icons and stock icons wherever it can... can you check if you still have some of those problems with the current trunk ?
Comment 5 Michael Monreal 2007-07-29 17:36:53 UTC
The "events" emblem still looks pre-tango to me, the rest seems to be fixed. Thanks!
Comment 6 Stephane Delcroix 2007-07-29 18:03:03 UTC
the event emblem is brand new...

I'm closing this now. thx Michael for taking care of details
Comment 7 Michael Monreal 2007-07-30 00:13:00 UTC
Woa... I checked the source tree and I see those new icons... also for places, readonly and people. I deleted the $prefix/lib/f-spot dir before installing f-spot and I still see the old icons, how is that possible?
Comment 8 Stephane Delcroix 2007-07-30 07:36:52 UTC
y, new icons are only for newcomers ;)

in _your_ db, the complete pixmap is stored for the tag, so no themability. In newly created db, the icon name is stored so we can follow the themes...

but you can have that option too... for each predefined tag (places, event, ...), right-click 'Edit Tag', then edit the icon, and select the right one from the 'Predefined' box. Now the icon name is stored in the db...

regards

s
Comment 9 Michael Monreal 2007-07-30 07:58:55 UTC
Ok, this worked for the fav, hidden, places and events icons. I however don' t see the new people icon in that list.
Comment 10 Stephane Delcroix 2007-07-30 08:05:14 UTC
that's because there's still en emblem-people icon in your version of gnome-icon-theme. I reported that to jimmac who removed it so you won't have it anymore with newest versions of gnome-icon-theme. In the meantime, select the old looking one...
Comment 11 Michael Monreal 2007-07-30 08:41:52 UTC
I removed share/icons/gnome and installed g-i-t trunk as of today. I don't see emblems-people in the emblems/ folders anywere, however f-spot still shows the old icon...