After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354968 - remember start size of evince window
remember start size of evince window
Status: RESOLVED DUPLICATE of bug 168450
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-08 14:01 UTC by Meik Hellmund
Modified: 2006-10-02 21:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
make evince use last window size for new documents (607 bytes, patch)
2006-09-08 14:02 UTC, Meik Hellmund
committed Details | Review

Description Meik Hellmund 2006-09-08 14:01:08 UTC
It seems the startup size of evince for new documents is unconfigurable. 
As long as there is nothing better, I suggest using the window size of the previous use of evince. This can be done by a trivial patch and I believe 
that I am not the only user who would see this as a big improvement. 
  
--- ev-window.c.orig    2006-09-08 14:12:30.000000000 +0200
+++ ev-window.c 2006-09-08 14:12:54.000000000 +0200
@@ -708,8 +708,8 @@ setup_view_from_metadata (EvWindow *wind
        }

        if (restore_size &&
-           ev_metadata_manager_get (uri, "window_width", &width, TRUE) &&
-            ev_metadata_manager_get (uri, "window_height", &height, TRUE)) {
+           ev_metadata_manager_get (uri, "window_width", &width, FALSE) &&
+            ev_metadata_manager_get (uri, "window_height", &height, FALSE)) {
                gtk_window_resize (GTK_WINDOW (window),
                                   g_value_get_int (&width),
                                   g_value_get_int (&height));




Other information:
Comment 1 Meik Hellmund 2006-09-08 14:02:47 UTC
Created attachment 72413 [details] [review]
make evince use last window size for new documents
Comment 2 Nickolay V. Shmyrev 2006-09-08 14:36:09 UTC
Dear Melk, can you please extend your patch so it will save ratio of document size and window size instead of window size? Sorry that I've delayed that since April, but with such change we'll certainly apply it.
Comment 3 Meik Hellmund 2006-09-08 16:57:41 UTC
Nickolay, I am not shure if I unterstand what you mean. I use almost always the 
"best fit" mode, i.e. the document is scaled to fit the window. And I want evince to start with a rather large window, filling most but not all of my screen.
Anyway, I think the document size is not the important parameter, since documents of the same size can have quite different font sizes. So I wouldn't say "I prefer evince window size=1.4 x document size". I say: I prefer, for my screen, evince to start with a window of this size and to scale the document accordingly". 
But usability opinions can differ greatly...
I could also live with a "--geometry" option as demanded in another bug.
Comment 4 Danny Yee 2006-09-11 07:37:50 UTC
This bug is enough to stop me using evince, when otherwise it would be my preferred PDF reader.

I have a 1920x1200 monitor, and every time I open a PDF with evince I get a tiny window in the top left corner.  I don't care how it's implemented - remember previous window size, a --geometry option, a .evincerc file - so long as there's some way of getting it to default to a large window in the middle of my display.
Comment 5 Nickolay V. Shmyrev 2006-10-02 21:36:31 UTC
Ok, I'll apply your patch, but let me mark this as a dup.

*** This bug has been marked as a duplicate of 168450 ***