After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354234 - Don't ignore terminal default sizes, and copy zoom to new terminals
Don't ignore terminal default sizes, and copy zoom to new terminals
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-04 07:12 UTC by Mariano Suárez-Alvarez
Modified: 2006-10-18 04:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do that. (1.29 KB, patch)
2006-09-04 07:13 UTC, Mariano Suárez-Alvarez 		none Details | Review

Description Mariano Suárez-Alvarez 2006-09-04 07:12:17 UTC 
If the xterm termcap installed by vte is edited so that the co and li entries have not their default values (which is vte's funny way of changing the default terminal size!) then g-t ignores this for the first tab of each window, and just uses 80x24. This is quite minor, as I doubt many people know they can edit the termcap...

The following patch fixes that and moreover makes a new tab have the same zoom factor as the active one. The approach is different from the one in the patch attached to comment 2 of bug 335200, «Remember zoom setting for new tabs». Both are more or less equivalent.
Comment 1 Mariano Suárez-Alvarez 2006-09-04 07:13:34 UTC 
Created attachment 72185 [details] [review]
Do that.
Comment 2 Mariano Suárez-Alvarez 2006-10-18 04:35:28 UTC 
Fixed in HEAD:

2006-10-17  Mariano Suárez-Alvarez  <msuarezalvarez@arnet.com.ar>

        Bug 354234 – Don't ignore terminal default sizes, and copy zoom to
        new terminals

        * src/terminal-window.c (notebook_tab_added_callback): do not hardcode
        the 80x24 size but use the default provided by vte (which could be
        changed in vte's termcap) Also, move the copy-zoom-from-active-terminal
        handling from new_tab_callback to here.