GNOME Bugzilla – Bug 353943
pyg_param_spec_getattr() truncates 64-bits integers
Last modified: 2006-11-18 13:24:52 UTC
pyg_param_spec_getattr() uses PyLong_FromLong for G_TYPE_INT64 and G_TYPE_UINT64. See attached patch and test file.
Created attachment 72062 [details] test
Created attachment 72063 [details] [review] patch
PS: there's also problems in handling of UINT and ULONG.
We're frozen for 2.12 so this can't go in just yet. Muntyan: Can you integrate the test with test_properties.py [and include it in the patch] please? You seem to have forgot a test for TYPE_INT64, and ideally all affected pspec attributes should be tested.
Created attachment 72080 [details] [review] new patch New patch with tests and TYPE_LONG problem fixed.
Forgot to mention, tests of signed types pspecs do not really test anything, but well, why not? They don't harm.
Created attachment 72081 [details] [review] new patch Sorry, screwed up the previous one.
*** Bug 354883 has been marked as a duplicate of this bug. ***
Checking in ChangeLog; /cvs/gnome/pygobject/ChangeLog,v <-- ChangeLog new revision: 1.113; previous revision: 1.112 done Checking in gobject/gobjectmodule.c; /cvs/gnome/pygobject/gobject/gobjectmodule.c,v <-- gobjectmodule.c new revision: 1.234; previous revision: 1.233 done Checking in gobject/pygparamspec.c; /cvs/gnome/pygobject/gobject/pygparamspec.c,v <-- pygparamspec.c new revision: 1.11; previous revision: 1.10 done Checking in tests/test_properties.py; /cvs/gnome/pygobject/tests/test_properties.py,v <-- test_properties.py new revision: 1.8; previous revision: 1.7 done