After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353943 - pyg_param_spec_getattr() truncates 64-bits integers
pyg_param_spec_getattr() truncates 64-bits integers
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: gobject
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
: 354883 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-02 08:33 UTC by Yevgen Muntyan
Modified: 2006-11-18 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test (350 bytes, text/plain)
2006-09-02 08:33 UTC, Yevgen Muntyan
  Details
patch (2.01 KB, patch)
2006-09-02 08:34 UTC, Yevgen Muntyan
none Details | Review
new patch (8.00 KB, patch)
2006-09-02 15:25 UTC, Yevgen Muntyan
none Details | Review
new patch (7.71 KB, patch)
2006-09-02 15:31 UTC, Yevgen Muntyan
none Details | Review

Description Yevgen Muntyan 2006-09-02 08:33:08 UTC
pyg_param_spec_getattr() uses PyLong_FromLong for G_TYPE_INT64 and G_TYPE_UINT64.
See attached patch and test file.
Comment 1 Yevgen Muntyan 2006-09-02 08:33:38 UTC
Created attachment 72062 [details]
test
Comment 2 Yevgen Muntyan 2006-09-02 08:34:18 UTC
Created attachment 72063 [details] [review]
patch
Comment 3 Gustavo Carneiro 2006-09-02 11:53:33 UTC
PS: there's also problems in handling of UINT and ULONG.
Comment 4 Johan (not receiving bugmail) Dahlin 2006-09-02 12:48:14 UTC
We're frozen for 2.12 so this can't go in just yet.

Muntyan: Can you integrate the test with test_properties.py [and include it in the patch] please? You seem to have forgot a test for TYPE_INT64, and ideally all affected pspec attributes should be tested.
Comment 5 Yevgen Muntyan 2006-09-02 15:25:03 UTC
Created attachment 72080 [details] [review]
new patch

New patch with tests and TYPE_LONG problem fixed.
Comment 6 Yevgen Muntyan 2006-09-02 15:26:03 UTC
Forgot to mention, tests of signed types pspecs do not really test anything, but well, why not? They don't harm.
Comment 7 Yevgen Muntyan 2006-09-02 15:31:19 UTC
Created attachment 72081 [details] [review]
new patch

Sorry, screwed up the previous one.
Comment 8 René Stadler 2006-10-06 17:54:55 UTC
*** Bug 354883 has been marked as a duplicate of this bug. ***
Comment 9 Johan (not receiving bugmail) Dahlin 2006-11-18 13:24:52 UTC
Checking in ChangeLog;
/cvs/gnome/pygobject/ChangeLog,v  <--  ChangeLog
new revision: 1.113; previous revision: 1.112
done
Checking in gobject/gobjectmodule.c;
/cvs/gnome/pygobject/gobject/gobjectmodule.c,v  <--  gobjectmodule.c
new revision: 1.234; previous revision: 1.233
done
Checking in gobject/pygparamspec.c;
/cvs/gnome/pygobject/gobject/pygparamspec.c,v  <--  pygparamspec.c
new revision: 1.11; previous revision: 1.10
done
Checking in tests/test_properties.py;
/cvs/gnome/pygobject/tests/test_properties.py,v  <--  test_properties.py
new revision: 1.8; previous revision: 1.7
done