After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353924 - "Any Category" not translated in contact selection dialog
"Any Category" not translated in contact selection dialog
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
1.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2006-09-01 23:36 UTC by André Klapper
Modified: 2013-09-10 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.95 KB, patch)
2006-11-01 17:36 UTC, Matthew Barnes
committed Details | Review

Description André Klapper 2006-09-01 23:36:09 UTC
addressbook or calendar > quick search > Show: "Any Category" *is* translated in the UI.

new > email > click on "to" button - dropdown default option "Any category" is not translated in the UI.
Comment 1 André Klapper 2006-09-15 03:45:26 UTC
the offending string is in e_name_selector_dialog_populate_categories() in libedataserverui/e-name-selector-dialog.c.

category_list = g_list_prepend (category_list, "Any Category");
must be marked for translation *and* it **must** be the first item in the dropdown list. currently the dropdown categories list is sorted alphabetically, so every user that has a category sorted before "Any Category" (imagine something like "Aaa") always has to change the category to "Any Category" manually to get all the contacts displayed, which is highly annoying.

srini, can this be done for 2.8?
Comment 2 Matthew Barnes 2006-11-01 17:36:16 UTC
Created attachment 75784 [details] [review]
Proposed patch

e_categories_get_list() already sorts the list (properly now, with this patch), so no need to sort it again in e_name_selector_dialog_populate_categories().  Also marked "Any Category" for translation.
Comment 3 Matthew Barnes 2006-11-11 00:54:38 UTC
Downstream bug report about the sorting issue:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215107

Can we get the patch reviewed in time for 2.8.2?
Comment 4 Srinivasa Ragavan 2006-11-19 17:41:45 UTC
Please commit Mathew. 
Comment 5 Matthew Barnes 2006-11-19 23:40:24 UTC
Committed to HEAD and gnome-2-16 branch.
Comment 6 Matthew Barnes 2006-11-19 23:41:16 UTC
This bug can be closed now.  I lack the permissions to do it myself.
Comment 7 Srinivasa Ragavan 2006-11-20 04:48:17 UTC
Thx Matthew.
Comment 8 André Klapper 2006-11-20 09:15:55 UTC
matthew, i've just given you bugzilla permissions, so now you can close bugs yourself. :-)
Comment 9 Matthew Barnes 2006-11-20 11:49:17 UTC
Thanks Andre!
Comment 10 Leslie Satenstein 2007-04-01 16:04:51 UTC
Gentlemen,

If this bug has been fixed, then why do I, in Fedora Test3  Have the problem.

Test3 is version 2.10.0

Leslie Satenstein
Comment 11 André Klapper 2007-04-01 19:30:05 UTC
Leslie, because it is a different bug, as already written and discussed in bug 424725?