After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353060 - Strings aren't translated in UI
Strings aren't translated in UI
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
1.8.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2006-08-27 03:44 UTC by Nickolay V. Shmyrev
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (651 bytes, patch)
2006-08-28 15:10 UTC, Nickolay V. Shmyrev
committed Details | Review
Preprocessed output (323.80 KB, text/x-csrc)
2006-10-13 20:34 UTC, Srinivasa Ragavan
  Details

Description Nickolay V. Shmyrev 2006-08-27 03:44:25 UTC
In evolution-data-server-1.7.92 messages for POP3 progress like:

"Expunging deleted messages" "Retrieving POP3 summary" 

aren't translated in Evolution progress dialog while receiving mail.
Comment 1 Nickolay V. Shmyrev 2006-08-28 08:51:43 UTC
Srinivasa, can you please look at this bug as well? 
Comment 2 André Klapper 2006-08-28 09:39:05 UTC
yes, the strings are translated in the po files, but not in the UI.
this isn't a critical bug. for future reference, please file mailer bugs under component mailer. thanks in advance. :-)
Comment 3 Srinivasa Ragavan 2006-08-28 13:26:03 UTC
Ive been trying hard, I dont seem to get the clue. Even I do a printf (_("Retrieving POP3 summary")) I get only english. Even glib/gi18.h doesnt help. 
Comment 4 Nickolay V. Shmyrev 2006-08-28 14:37:57 UTC
I've investigated a bit, the reason is that in plugin textdomain = evolution-2.8 while it should be evolution-data-server-1.8, currently I am looking on the way to fix it.

Comment 5 Nickolay V. Shmyrev 2006-08-28 14:49:56 UTC
It's related to the bug 300891
Comment 6 Nickolay V. Shmyrev 2006-08-28 15:10:59 UTC
Created attachment 71780 [details] [review]
Proposed patch

This patch will fix the problem, unifying pop3 with other providers.
Comment 7 Srinivasa Ragavan 2006-08-28 17:06:34 UTC
Nickolay, it doesnt seem to work for me. Are you sure this is the right fix?
Comment 8 Nickolay V. Shmyrev 2006-08-28 17:28:54 UTC
It works for me.

Are you sure you've regeneraged Makefiles? Check that this defines appears in 
compilations string for pop3 provider.
Comment 9 Nickolay V. Shmyrev 2006-08-28 17:38:53 UTC
If you added glib/gi18n, you should remove it as well, you need to include camel-i18n.h
Comment 10 Nickolay V. Shmyrev 2006-10-13 08:35:29 UTC
Ping on this problem. It's rather annoying since visibility is very high.
Comment 11 Srinivasa Ragavan 2006-10-13 17:44:40 UTC
Nickolay, I set LANG=mk_MK.utf8 I checked the mk.po and the string is translated.
Also I applied the patch and did make clean and make install.


 gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../intl -I../../../camel -pthread -DORBIT2=1 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -I/opt/gnome/include/gnome-vfs-2.0 -I/opt/gnome/lib/gnome-vfs-2.0/include -I/opt/gnome/include/bonobo-activation-2.0 -I/opt/gnome/include/libbonobo-2.0 -I/opt/gnome/include/gconf/2 -I/opt/gnome/include/orbit-2.0 -I/usr/include -I/usr/include/nspr4/ -I/usr/include/nss3 -D_LARGEFILE64_SOURCE -DCAMEL_EXPLICIT_TRANSLATION_DOMAIN=\"evolution-data-server-1.8\" -DG_LOG_DOMAIN=\"camel-pop3-provider\" -g -O2 -Wall -Wmissing-prototypes -Wno-sign-compare -MT camel-pop3-provider.lo -MD -MP -MF .deps/camel-pop3-provider.Tpo -c camel-pop3-provider.c  -fPIC -DPIC -o .libs/camel-pop3-provider.o

I have pasted a snap of make install. It has the patch applied. It still shows in english in SEND/Receive on POP accounts. Can any one else verify it? Am I doing something wrong?
Comment 12 Nickolay V. Shmyrev 2006-10-13 19:51:06 UTC
Srinivasa, can you please attach the preprocessed camel-pop3-folder.c? You can just add -E option to comilation string or use the following script:

#!/bin/sh

prefix=/opt/gnome

gcc -E -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../intl \
-I../../../camel -pthread -DORBIT2=1 -I$prefix/include/glib-2.0 \
-I$prefix/lib/glib-2.0/include -I$prefix/include/gnome-vfs-2.0 \
-I$prefix/lib/gnome-vfs-2.0/include \
-I$prefix/include/bonobo-activation-2.0 \
-I$prefix/include/libbonobo-2.0 -I$prefix/include/gconf/2 \
-I$prefix/include/orbit-2.0 -I$prefix -I$prefix/nspr4/ \
-I$prefix/nss3 -D_LARGEFILE64_SOURCE \
-DCAMEL_EXPLICIT_TRANSLATION_DOMAIN=\"evolution-data-server-1.8\" \
-DG_LOG_DOMAIN=\"camel-pop3-provider\" -g -O2 -Wall -Wmissing-prototypes \
-Wno-sign-compare -MT camel-pop3-folder.lo -MD -MP -MF \
.deps/camel-pop3-folder.Tpo -c camel-pop3-folder.c  -fPIC -DPIC -o \
result.c
Comment 13 Nickolay V. Shmyrev 2006-10-13 20:23:49 UTC
Also please check with strace that message catalogs are found in correct place
Comment 14 Srinivasa Ragavan 2006-10-13 20:34:08 UTC
Created attachment 74655 [details]
Preprocessed output

Let me know if that helps.
Comment 15 Nickolay V. Shmyrev 2006-10-13 20:49:41 UTC
Looks fine, now what about strace from evolution-data-server?
Comment 16 Sebastien Bacher 2006-10-16 19:16:46 UTC
That patch makes the string translation beeing used on Ubuntu edgy with GNOME 2.16.1 too
Comment 17 Kjartan Maraas 2006-12-03 15:26:43 UTC
Any news here? Would be nice to get this fixed once and for all.
Comment 18 André Klapper 2007-01-07 03:41:02 UTC
srini: *ping* - comment 16, patch at comment 6? :-)
Comment 19 Srinivasa Ragavan 2007-01-07 09:57:45 UTC
Hmm, I think it should be OK to commit the patch and test this out. For some reasons it didnt work out for me. It is better to go this way.
Comment 20 Nickolay V. Shmyrev 2007-01-10 23:55:26 UTC
Applied, thanks.