GNOME Bugzilla – Bug 352695
Search and the clear looses the expanded state of my threads
Last modified: 2008-08-11 14:20:29 UTC
It defaults to expanded all, and it looses all my expanded state information.
Created attachment 71536 [details] [review] Proposed patch
confirming behaviour.
fixed to head.
The if-statement does nothing because ml->search won't be null if no search is given. Since save_tree_state is never called right now, at least one other issue is triggered: bug 387312 So this issue has not been fixed with this workaround. As I consider #387312 more intrusive, I suggest to apply the following patch which restores old behaviour, but fixes #387312. To trigger this issue, do following steps: - Group by thread - Collapse all threads - Expand a single thread - type smth in the search bar hit enter - clear the search bar - watch all threads being collapsed (they expand if this would be you default)
Created attachment 92864 [details] [review] Proposed patch which removes dead if statement
Tobias, I think it is fine. Commit this patch for bug #387312 and leave this open and fix it :)
Commited as rev 33930
Bumping version to a stable release.
Created attachment 116129 [details] [review] proposed evo patch for evolution; a bit different approach.
Hey Milan :) You're just awesome :) Just a sidenote: I think this: + g_return_if_fail (et != NULL); + g_return_if_fail (E_IS_TREE (et)); is not necessary as the E_IS_TREE *should* check for NULL already. I dunno whether it does it though. Besides that, I didn't check the patch.
Yeah, that's right. The reason why I do this in two checks is that I want to distinguish between NULL and between broken memory. If I do that in the your way, then I cannot.
Anyways, commit to trunk. Looks awesome.
Committed to trunk. Committed revision 35953.
Errr, I caused an error with this. When you try to change the Show filter, say from "All Messages" to "Read Messages", then after this change the message list is locked, and doesn't scroll with cursor like it used to. I realized I forgot to move one event emit to the _xml function. I'm sorry for that.
Created attachment 116347 [details] [review] proposed evo patch (error fix) for evolution;
Approved.
Committed to trunk. Committed revision 35955. Thanks, such a stupid mistake I did.