After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352595 - crash in Deskbar: The error is quite persi...
crash in Deskbar: The error is quite persi...
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
unspecified
Other All
: High critical
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
: 352622 352679 352702 352760 352769 352803 352990 353321 353332 353365 353368 353374 353427 353466 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-23 21:11 UTC by Aleksander Kamil Modzelewski
Modified: 2006-08-29 23:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch. Entirely untested (2.13 KB, patch)
2006-08-26 20:54 UTC, Mikkel Kamstrup Erlandsen
committed Details | Review
Backtrace (2.67 KB, text/plain)
2006-08-28 08:52 UTC, Aleksander Kamil Modzelewski
  Details
The escaped_uri field was not set properly (1.91 KB, patch)
2006-08-28 19:22 UTC, Mikkel Kamstrup Erlandsen
none Details | Review
take two (1.91 KB, patch)
2006-08-28 19:40 UTC, Mikkel Kamstrup Erlandsen
none Details | Review
Another set of tracebacks (3.54 KB, text/plain)
2006-08-29 12:37 UTC, Aleksander Kamil Modzelewski
  Details

Description Aleksander Kamil Modzelewski 2006-08-23 21:11:23 UTC
What were you doing when the application crashed?
The error is quite persistent, happens always when searching with beagle-live enabled.


Distribution: Ubuntu 6.10 (edgy)
Gnome Release: 2.15.92 2006-08-22 (Ubuntu)
BugBuddy Version: 2.15.92

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0

Traceback (most recent call last):
  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 262 in _on_snippet_closed
    self._on_hit_added(query, container, qstring, qmax)
  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 340 in _on_hit_added
    match = BeagleLiveMatch(self, result)
  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 170 in __init__
    self.result["text"] = self.result["text"].replace("'", "\\'")
KeyError: 'text'

Comment 1 Mikkel Kamstrup Erlandsen 2006-08-24 15:46:14 UTC
*** Bug 352679 has been marked as a duplicate of this bug. ***
Comment 2 Mikkel Kamstrup Erlandsen 2006-08-24 15:49:23 UTC
*** Bug 352622 has been marked as a duplicate of this bug. ***
Comment 3 Nigel Tao 2006-08-25 01:13:01 UTC
*** Bug 352702 has been marked as a duplicate of this bug. ***
Comment 4 Nigel Tao 2006-08-25 01:14:04 UTC
*** Bug 352760 has been marked as a duplicate of this bug. ***
Comment 5 Tim Fuchs 2006-08-25 01:32:43 UTC
*** Bug 352769 has been marked as a duplicate of this bug. ***
Comment 6 Ricky Moorhouse 2006-08-25 08:24:30 UTC
*** Bug 352803 has been marked as a duplicate of this bug. ***
Comment 7 Ricky Moorhouse 2006-08-25 08:27:05 UTC
This happens consistently for me as well with Beagle Live enabled, whatever
the search is.

If I disable Beagle Live, it works without crashing
Comment 8 Mikkel Kamstrup Erlandsen 2006-08-26 20:51:42 UTC
*** Bug 352990 has been marked as a duplicate of this bug. ***
Comment 9 Mikkel Kamstrup Erlandsen 2006-08-26 20:54:02 UTC
Created attachment 71680 [details] [review]
Proposed patch. Entirely untested

The problem seems to be that the "text" field is never added to the self.result dict. The attached patch tried to get around this.

NOTE: I have not tested this patch at all - can anyone give feedback?
Comment 10 pecanov 2006-08-27 06:13:42 UTC
I just applied it and it seems to work fine.
Comment 11 Mikkel Kamstrup Erlandsen 2006-08-28 06:28:18 UTC
Cool pecanov. At this point in the release process I would like atleast one other confirmation before I commit. Anyone?
Comment 12 Aleksander Kamil Modzelewski 2006-08-28 08:17:59 UTC
The patch seems to work here. Thank you :-)
Comment 13 Aleksander Kamil Modzelewski 2006-08-28 08:52:02 UTC
Created attachment 71750 [details]
Backtrace

OK, almost: now I have errors in preferences window and while searching. The search error disappears when beagle-live is disabled, preferences error does not and maybe it's unrelated.
Comment 14 Aleksander Kamil Modzelewski 2006-08-28 09:03:52 UTC
Oh, the search crash appeared when I made a search for something that should return a directory with national characters and spaces. Neither the search bug nor the one in preferences window does not happen as long as I search only for things without national characters in their names/urls.
Comment 15 Mikkel Kamstrup Erlandsen 2006-08-28 18:59:21 UTC
Ok, I committed the patch.

Aleksander: The second stack trace is a known bug #352874. However it would be greatly helpful if you could find a way to reproduce the bug. Another thing I might persuade you into doing; could you file a bug about the first stacktrace - the one with the national characters?
Comment 16 Mikkel Kamstrup Erlandsen 2006-08-28 19:22:43 UTC
Created attachment 71795 [details] [review]
The escaped_uri field was not set properly

Aleksander: Hold it with the bug filing :-) Make sure you update your cvs to get the last patch and then try this patch, and let me know how it works.
Comment 17 Mikkel Kamstrup Erlandsen 2006-08-28 19:40:28 UTC
Created attachment 71796 [details] [review]
take two

The old patch broke beagle-live. If somebody already applied it you can reverse a patch with "patch -R < mypatch.patch", or just delete the broken file and re-update cvs.
Comment 18 Mikkel Kamstrup Erlandsen 2006-08-29 05:09:03 UTC
*** Bug 353321 has been marked as a duplicate of this bug. ***
Comment 19 Mikkel Kamstrup Erlandsen 2006-08-29 05:38:26 UTC
*** Bug 353332 has been marked as a duplicate of this bug. ***
Comment 20 Nigel Tao 2006-08-29 11:00:31 UTC
*** Bug 353374 has been marked as a duplicate of this bug. ***
Comment 21 Nigel Tao 2006-08-29 11:01:00 UTC
*** Bug 353365 has been marked as a duplicate of this bug. ***
Comment 22 Aleksander Kamil Modzelewski 2006-08-29 12:37:05 UTC
Created attachment 71826 [details]
Another set of tracebacks

OK, almost works, but: the folders open OK. The text files with national characters in file names won't open. The text files with plain-ascii names open, but there are tracebacks in deskbar -w output. Tested both on patched Ubuntu distro and fresh cvs checkout :-)

Thanks :> (deskbar no longer fails when searching, and that's really nice :-))
Comment 23 Ricky Moorhouse 2006-08-29 13:59:23 UTC
The new patch still seems to crash my deskbar, I get the following

Distribution: Ubuntu 6.10 (edgy)

Gnome Release: 2.15.92 2006-08-22 (Ubuntu)

BugBuddy Version: 2.15.92



Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0

CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0



Traceback (most recent call last):

  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 261 in _on_snippet_received
  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 340 in _on_hit_added
  • File "/usr/lib/deskbar-applet/handlers/beagle-live.py", line 173 in __init__
KeyError: 'text'

Comment 24 Aleksander Kamil Modzelewski 2006-08-29 14:07:14 UTC
Ricky, did You apply both of the non-obsolete patches? The second one fixes the other problem I mentioned in this bug, but this traceback seems like the problem that I reported first (and which works for me, at least).

OTOH, should I submit the national characters problem in another bug? Maybe that's a dumb question, but I'm still a bit shy about this bug-submitting thing :-)
Comment 25 Raphael Slinckx 2006-08-29 14:32:18 UTC
*** Bug 353368 has been marked as a duplicate of this bug. ***
Comment 26 Raphael Slinckx 2006-08-29 14:36:59 UTC
Please keep different issues in different bugs even if slightly related. Thanks for your contributions !
Comment 27 Ricky Moorhouse 2006-08-29 15:44:31 UTC
(In reply to comment #24)
> Ricky, did You apply both of the non-obsolete patches? The second one fixes the
> other problem I mentioned in this bug, but this traceback seems like the
> problem that I reported first (and which works for me, at least).

No I hadn't - my mistake I misread the comments!


With both of the non-obsolete patches it now works fine

Comment 28 Karsten Bräckelmann 2006-08-29 23:13:49 UTC
*** Bug 353427 has been marked as a duplicate of this bug. ***
Comment 29 Karsten Bräckelmann 2006-08-29 23:15:00 UTC
*** Bug 353466 has been marked as a duplicate of this bug. ***