GNOME Bugzilla – Bug 352450
Don't call deprecated GLib / GDK functions
Last modified: 2013-09-13 00:52:30 UTC
I thought it would be a good housekeeping exercise to try and shake out some of the deprecated GLib and GDK symbols that Evolution is still using. I posted these patches to evolution-patches@gnome.org recently (see [1] and [2]), but I think a bug report will give them more visibility. Note that I only fixed symbols that had a simple 1-for-1 replacement. A couple custom widgets are still using GdkFont instead of Pango, but I'm leaving them alone for now because fixing them properly would require changing their APIs. To reproduce: $ CFLAGS="-DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED=1 > -DGDK_DISABLE_DEPRECATED=1" ./configure; make I also tried this with evolution-data-server-1.7.91 and evolution-connector-2.7.91, but they compiled successfully. I plan to do a similar exercise with deprecated GTK+ symbols, but I'll file a separate bug report for that since it'll require a bit more work. [1] http://mail.gnome.org/archives/evolution-patches/2006-August/msg00059.html [2] http://mail.gnome.org/archives/evolution-patches/2006-August/msg00061.html
Created attachment 71402 [details] Progress log
Created attachment 71403 [details] [review] Patch for deprecated GLib symbols
Created attachment 71404 [details] [review] Patch for deprecated GDK symbols
thanks a lot for them! for future reference, can i ask you to "cvs diff -pu" and to also add changelog entries? tia
Sure thing. How detailed should the ChangeLog entry be for something like this? Should I document each function or will a blanket "do not use deprecated GLib or GDK symbols" comment in each of the relevant ChangeLogs suffice?
just refer to previous entries in the changelog file, i'd say - at least i of course list the filename, but do not list the function name (emacs does the latter automatically, afaik). thanks a lot in advance.
like http://cvs.gnome.org/viewcvs/evolution/mail/ChangeLog?r1=1.3897&r2=1.3898 , for example (i guess, we don't have guidelines for committing patches on behalf of others - i prefer to add the name of the person that provided the patch, others use their own names and add a comment who submitted the patch - anyway). please include a reference to the bug number, i forgot to write in my last comment.
Created attachment 71476 [details] [review] Patch with ChangeLog entries in the preferred format This patch covers both deprecated GLib and GDK symbols.
Mathew : The patch looks good. Please commit them to the trunk (this is also Evolution 2.8 ATM). Thanks again for the effort and these wonderful patches :-).
Still waiting for a CVS account, it seems. Someone will have to commit this on my behalf.
Committed the changes. BTW, I remember endorsing your request last week - so you should be getting the account soon..