After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352423 - Uninitialized GErrors in Evolution
Uninitialized GErrors in Evolution
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-08-22 16:43 UTC by Matthew Barnes
Modified: 2013-09-13 00:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Proposed patch (810 bytes, patch)
2006-08-22 16:46 UTC, Matthew Barnes 		committed Details | Review
Proposed patch #2 (1.09 KB, patch)
2006-08-22 16:54 UTC, Matthew Barnes 		committed Details | Review

Description Matthew Barnes 2006-08-22 16:43:45 UTC 
While I'm still thinking about bug #349847, I thought I'd take a look at Evolution.  I found a few cases of uninitialized GErrors here too.
Comment 1 Matthew Barnes 2006-08-22 16:46:48 UTC 
Created attachment 71376 [details] [review]
Proposed patch

These cases are definitely errors.
Comment 2 Matthew Barnes 2006-08-22 16:54:14 UTC 
Created attachment 71377 [details] [review]
Proposed patch #2

These cases are not errors, but they look suspicious when grep'ing the source code for uninitialized GErrors.  In the interest of doing future searches for this type of error, I changed the logic to look less suspicious.
Comment 3 Srinivasa Ragavan 2006-08-23 07:46:34 UTC 
Looks fine to commit.
Comment 4 Srinivasa Ragavan 2006-08-23 08:05:41 UTC 
resetting the mode.
Comment 5 André Klapper 2006-08-23 08:07:40 UTC 
firefox is buggy and sucks with regard to reloading dropdown menu values. sorry for the noise.
Comment 6 André Klapper 2006-08-23 08:44:57 UTC 
committed both patches to CVS HEAD.
fixes will be included in Evolution 2.8.0.
matthew, thanks for the patches, like always. :-)