GNOME Bugzilla – Bug 352268
Location of G_GNUC_INTERNAL breaks Solaris build
Last modified: 2008-01-15 14:08:10 UTC
gimp makes extensive use of the G_GNUC_INTERNAL macro. For the Solaris forte compiler this must be placed at the start of the line. Can you please apply the attached patch - it moves the macro 73 times. This will not affect gcc - it does not care where the macro is placed.
Created attachment 71318 [details] [review] Move G_GNUC_INTERNAL to the start of the line
See also 350606 (gtk-engines) and 352981 (glib). 350606 has a link to a cairo change where they resolved this issue with a private macro.
I would apply the patch but it needs some more work before it can be applied. As it stands, it completely breaks the horizontal alignment in the header files.
Bug #352981 (glib) does not exist. Damien, if you refer to other bugs in Bugzilla, please prepend "bug " to the bug number so that Bugzilla creates a link.
Darn, one digit wrong. bug 342981 is the glib bug about this issue.
Just realized that large parts of the patch affect autogenerated code. I will have a look at changing the code generator. That will probably catch most places where G_GNUC_INTERNAL is being used.
Should be FIXED now. Please reopen if there are still problems. 2006-08-22 Sven Neumann <sven@gimp.org> * libgimpbase/gimpwire.h * libgimpbase/gimpreloc.h * libgimp/gimpdrawablepreview.h * libgimp/gimptile.h * libgimp/gimpunitcache.h * libgimpthumb/gimpthumb-utils.h * libgimpwidgets/gimpcolorarea.h * libgimpwidgets/gimphelpui.h: moved G_GNUC_INTERNAL before the return value (bug #352268). * tools/pdbgen/lib.pl : changed code generation rules to place G_GNUC_INTERNAL before the return value. * libgimp/*_pdb.h: regenerated.