GNOME Bugzilla – Bug 352118
does not handle non-unique filenames on CD export
Last modified: 2006-09-01 15:51:41 UTC
Please describe the problem: I have a camera that generates files like HASH-PREFIX/dscCOUNT.jpg . I can import this with f-spot from USB disk. The result is that I many different photos named dsc0001.jpg. When I create a CD containing all of these different dsc0001.jpgs, all of these overwrite each other, and I end up with too few photos on the CD. Please add -DISAMBIGUATION-COUNT suffix to the file names when encountering duplicate names. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. Thanks for another specific sample. I will add this information to the other bug report #348091 *** This bug has been marked as a duplicate of 348091 ***
Created attachment 71308 [details] [review] a patch that fix this bug This patch ensure file uniqueness when exporting to CD. I needed to write a new UniqueName method working on Gnome.Vfs.Uri's, so we can't see this as a dup of bug #348091 anymore... Bengt, what do you think ?
The patch looks good to me. Ok, I'll agree and re-open this bug then. Still think that in an abstract way this should be handled in the same way (possible with some unique coding though) for all export methods.
yeah we need to fix this in general but I'll put this in for now
I'm sorry Larry, you committed the changes to Changelog, but not in CDExport.cs
now it is !