Created attachment 70933 [details] [review]
patch

Comment on attachment 70933 [details] [review]
patch

The patch seems to have some problems, it changes the attribution of too much of the .glade file.  Also, we should not be using document_if_type, only document_if_locale and document_if_attributes.

Lastly, I am not a maintainer of at-poke (officially), so I can't approve these patches.

Created attachment 71441 [details] [review]
patch v2

Removed document_type part.

I've no experience with .glade2 files, so I don't know how to make a better patch for at-poke.glade2.

The patch looks fine to me - but this code:

Is more normally done with a GString and g_string_append ...

+	attributes_str = g_strdup ("");
+	for ( i = 0; i < attributeSet->len; ++ i)
+	  {
+	    tmp = g_strconcat (attributes_str,
+			       (i == 0) ? "" : " ",
+			       attributeSet->attributes [i],
+			       (i != attributeSet->len - 1) ? ";" : "",
+			       NULL);
+	    g_free (attributes_str);
+	    attributes_str = tmp;

Otherwise this looks lovely.

Are there any document events that we should be displaying / decoding ?

Otherwise - it'd be great if someone could commit this :-)

Thanks.

Thanks Michael.  Michael and Ginn, if you don't mind, I'll make the small change suggested above and commit the resulting patch.

Ginn I agree that it may be hard to know how to reduce the size of the .glade diff.

Also Michael, is my patch for RFE 345706 OK to commit?  I could merge with this patch.

Created attachment 71481 [details] [review]
patch merged with patch for bug 345706, as applied.

Thanks Michael and Ginn!