After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351426 - API: add gst_tag_parse_extended_comment
API: add gst_tag_parse_extended_comment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 347091 348762
 
 
Reported: 2006-08-15 11:02 UTC by Tim-Philipp Müller
Modified: 2006-08-16 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
propsed API addition, incl. unit tests (9.70 KB, patch)
2006-08-15 11:03 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2006-08-15 11:02:47 UTC
I'd like to add a utility function to parse GST_TAG_EXTENDED_COMMENT strings. This is useful both for applications and tag-writing plugins and avoids code duplication:


gboolean
gst_tag_parse_extended_comment (const gchar  * ext_comment,
                                gchar       ** key,
                                gchar       ** lang,
                                gchar       ** value,
                                gboolean       fail_if_no_key);

Patch including unit test attached.
Comment 1 Tim-Philipp Müller 2006-08-15 11:03:39 UTC
Created attachment 70932 [details] [review]
propsed API addition, incl. unit tests
Comment 2 Tim-Philipp Müller 2006-08-16 11:37:57 UTC
Committed:

 2006-08-16  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/libs/gst-plugins-base-libs-sections.txt:
        * gst-libs/gst/tag/tag.h:
        * gst-libs/gst/tag/tags.c: (gst_tag_parse_extended_comment):
          API: add gst_tag_parse_extended_comment() (#351426).

        * tests/check/Makefile.am:
        * tests/check/libs/.cvsignore:
        * tests/check/libs/tag.c: (GST_START_TEST), (tag_suite), (main):
          Add unit test for gst_tag_parse_extended_comment().