After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351415 - (some) ffenc produce garbled results
(some) ffenc produce garbled results
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.1
Other Linux
: Normal normal
: 0.10.2
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-15 10:08 UTC by Mark Nauwelaerts
Modified: 2006-08-16 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch (471 bytes, patch)
2006-08-15 10:20 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-08-15 10:08:32 UTC 
The following pipeline (and resulting file) should allow to reproduce:
videotestsrc num-buffers=250  ! ffenc_msmpeg4 ! avimux ! filesink location=test.avi

The same problem is present for msmpeg4v2, mjpeg (and possibly others), though not for e.g. mpeg4
Comment 1 Mark Nauwelaerts 2006-08-15 10:20:51 UTC 
Created attachment 70928 [details] [review]
Possible patch

According to comments in avcodec.h, rtp_mode may be obsolete.
As such, current gstffmpegenc.c code may actually set/activate rtp_mode (because of rtp_payload_size), even when it is not intended.
The low value seems to make some codecs choke and will likely affect the encoding of other codecs as well, even when not requested by property settings.
Comment 2 Wim Taymans 2006-08-16 09:18:56 UTC 
        Patch by: Mark Nauwelaerts <manauw at skynet dot be>

        * ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_setcaps):
        If we are not operating in RTP mode, leave the default rtp encoder
        settings as they are so that we don't unintentionally activate it.
        Fixes #351415.