After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351317 - Typo in libedataserverui/Makefile.am
Typo in libedataserverui/Makefile.am
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
1.8.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-08-14 16:36 UTC by Matthew Barnes
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (447 bytes, patch)
2006-08-14 16:37 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2006-08-14 16:36:46 UTC
A bug report downstream [1] led me to the following stanza in libedataserverui's Makefile.am:

    37: if OS_WIN32
    38: libedataserverui_1_2_la_LIBADD =                                \
    39:         $(top_builddir)/addressbook/libebook/libebook-1.2.la    \
    40:         $(top_builddir)/libedataserver/libedataserver-1.2.la    \
    41:         $(E_DATA_SERVER_UI_LIBS)
    42: else
    43: libedataserverui_1_2_la_LIBADD =                                \
    44:         $(top_builddir)/addressbook/libebook/libebook-1.2.la    \
    45:         $(E_DATA_SERVER_LIBS)
    46: endif

On line 45, I'm pretty sure that's a typo.

Replace $(E_DATA_SERVER_LIBS) with $(E_DATA_SERVER_UI_LIBS).

[1] http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202329
Comment 1 Matthew Barnes 2006-08-14 16:37:32 UTC
Created attachment 70871 [details] [review]
Proposed patch
Comment 2 André Klapper 2006-08-20 12:37:27 UTC
harish: poke - patch attached
Comment 3 Srinivasa Ragavan 2006-08-21 15:40:52 UTC
http://cvs.gnome.org/viewcvs/evolution-data-server/libedataserverui/Makefile.am?r1=1.14&r2=1.15

The above commit caused this. Looks like both might be required. 
Comment 4 Srinivasa Ragavan 2006-08-23 09:25:59 UTC
Fixed to HEAD. The patch itself is sufficient.