After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351223 - the conjuction of Con + 0x0d4d +0x0d31 of Malayalam is wrong
the conjuction of Con + 0x0d4d +0x0d31 of Malayalam is wrong
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: indic
unspecified
Other All
: Normal normal
: ---
Assigned To: Behdad Esfahbod
Pango Indic
Depends on:
Blocks:
 
 
Reported: 2006-08-14 01:54 UTC by LingNing Zhang
Modified: 2006-09-13 23:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
my patch (1.39 KB, patch)
2006-08-14 08:11 UTC, LingNing Zhang
needs-work Details | Review
modified patch (1.51 KB, patch)
2006-09-11 06:19 UTC, LingNing Zhang
committed Details | Review

Description LingNing Zhang 2006-08-14 01:54:41 UTC
Please describe the problem:
The conjuction of Con + 0x0d4d +0x0d31 of Malayalam is wrong. Its glyph need be the same as the conjuction of Con + 0x0d4d +0x0d30.

Steps to reproduce:
 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 LingNing Zhang 2006-08-14 08:11:15 UTC
Created attachment 70853 [details] [review]
my patch

I wrote a patch to handle the special conjuction of Cons + 0x0d4d + 0x0d31 of Malayalam.
Comment 2 Behdad Esfahbod 2006-09-08 17:00:23 UTC
Can you add a function:

static void swapChars(Output *output, int a, int b)

and then call

+	    if ((baseConsonant - 2 >= 0) &&
+		(chars[baseConsonant - 1] == 0x0d4d) &&
+		(chars[baseConsonant] == 0x0d31) &&
+		((chars[baseConsonant - 2] >= 0x0d15) && 
+		 (chars[baseConsonant - 2] <= 0x0d39)))  {
+              swapChars (&output, -1, -3);
Comment 3 Behdad Esfahbod 2006-09-08 17:26:41 UTC
Also, can't you fix this by changing some property in some table?
Comment 4 LingNing Zhang 2006-09-11 02:06:04 UTC
ok, I will do it.
This is a speical conjuction's rule of Malayalam, it is very different with the common conjuctions' rule of Indic. So it can not be fixed by changing some property in some table.
Comment 5 LingNing Zhang 2006-09-11 06:19:31 UTC
Created attachment 72532 [details] [review]
modified patch

I modified the patch.
Comment 6 Behdad Esfahbod 2006-09-13 23:04:10 UTC
2006-09-13  Behdad Esfahbod  <behdad@gnome.org>

        Bug 351223 – the conjuction of Con + 0x0d4d +0x0d31 of Malayalam is
        wrong
        Patch from LingNing Zhang

        * modules/indic/indic-ot.c (swapChars), (indic_ot_reorder): Special
        case the above case.