After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350854 - Orca should handle object:state-changed:focus events
Orca should handle object:state-changed:focus events
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-11 08:18 UTC by Willie Walker
Modified: 2008-07-01 15:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Patch to set locus of focus on object:state-changed:focus events (3.86 KB, patch)
2006-08-11 08:30 UTC, Willie Walker
committed Details | Review
Rework of the patch to move the required code into the gedit script. (2.22 KB, patch)
2006-08-28 22:38 UTC, Rich Burridge
committed Details | Review

Description Willie Walker 2006-08-11 08:18:00 UTC
Sometimes an object will only emit object:state-changed:focus events, even though it should also emit focus: events.  An example of this is GEdit's edit area under GNOME 2.15: when one uses the metacity window menu to maximize/unmaximize a window, the edit area will only issue a object:state-changed:focus event.  Orca should attempt to handle this and do the appropriate thing.
Comment 1 Willie Walker 2006-08-11 08:30:33 UTC
Created attachment 70698 [details] [review]
Patch to set locus of focus on object:state-changed:focus events

This patch does two things:

1) When it detects caret moved events for focused text areas that are not the locus of focus, it sets the locus of focus to the text area.  This is somewhat passive fix and is also what we do in onText{Inserted,Deleted}.

2) When it detects an object:state-changed:focused event with a positive detail1, it sets the locus of focus to the event source.  This is potentially a risky change since it applies to all object:state-changed:focused events.  If this is shown to cause problems, we can remove this logic, but keep the logic in #1.
Comment 2 Willie Walker 2006-08-11 08:31:19 UTC
Fixed in the development version. The fix will be available in the next major release (0.2.9). Thank you for your bug report.
Comment 3 Rich Burridge 2006-08-28 22:24:49 UTC
Reopening the bug. The fix caused StarOffice/OpenOffice to double
speak lines in Writer. See bug #353268 for more details.
Comment 4 Rich Burridge 2006-08-28 22:38:19 UTC
Created attachment 71803 [details] [review]
Rework of the patch to move the required code into the gedit script.
Comment 5 Rich Burridge 2006-08-28 22:39:54 UTC
New changes checked into CVS HEAD. Closing as FIXED.
Comment 6 Rich Burridge 2006-08-28 22:43:02 UTC
That last line of the diff should of course be:

     default.Script.onStateChanged(self, event)

Adjustment committed to CVS HEAD.

Thanks Will.