After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350190 - Need specific icon for GTK_ICON_SIZE_SMALL_TOOLBAR for close icon
Need specific icon for GTK_ICON_SIZE_SMALL_TOOLBAR for close icon
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 350176 350177
 
 
Reported: 2006-08-06 20:30 UTC by Baptiste Mille-Mathias
Modified: 2014-01-23 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use 16px as default button and small toolbar icon sizes (2.28 KB, patch)
2014-01-23 03:44 UTC, William Jon McCann 		committed Details | Review

Description Baptiste Mille-Mathias 2006-08-06 20:30:31 UTC 
Hello,

at this time, GTK_ICON_SIZE_SMALL_TOOLBAR and GTK_ICON_SIZE_LARGE_TOOLBAR share the same icon for GTK_STOCK_CLOSE (at least), at it ends to bugs 350176 and 350177 .
Nautilus use a workaround by using GTK_ICON_SIZE_MENU, but would be great to have a small size for this icon to have consistent close button for sidebar.
Comment 1 Baptiste Mille-Mathias 2006-08-06 20:31:40 UTC 
oups sorry
Comment 2 Rodney Dawes 2006-08-07 01:15:31 UTC 
I'm not sure this should be an icon theme bug. GTK+ is requesting silly sizes for GTK_ICON_SIZE_BUTTON and GTK_ICON_SIZE_SMALL_TOOLBAR. 20 and 18 px respectively. Drawing all the possible stock icons in these weird sizes seems like a bit much.
Comment 3 Jakub Steiner 2007-01-26 15:01:51 UTC 
Another solution is to use thresholding to avoid the nasty bitmap scaling...

Use 16x16 bitmaps until the size of 21x21, then 22x22 until the size of 31x31, then 32x32px until 48x48 and then scale the SVG up.
Comment 4 Jakub Steiner 2010-03-03 17:46:56 UTC 
Asking icon themes to create 18x18 and 20x20px sizes in addition to the common 16x16, 22x22, 24x24, 32x32, 48x48 and now 256x256px is not the way. gtk should request either 22x22px for these or 16x16.

No icon theme in existence provides 20x20 or 18x18 as far as I know.
Comment 5 William Jon McCann 2014-01-23 03:44:46 UTC 
Created attachment 267017 [details] [review]
Use 16px as default button and small toolbar icon sizes
Comment 6 William Jon McCann 2014-01-23 17:55:45 UTC 
Attachment 267017 [details] pushed as b617b00 - Use 16px as default button and small toolbar icon sizes