After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349943 - [QOS] documentation/code mismatch
[QOS] documentation/code mismatch
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Reported: 2006-08-04 14:43 UTC by Julien MOUTTE
Modified: 2006-08-11 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Julien MOUTTE 2006-08-04 14:43:08 UTC
part-qos.txt mentions Jitter as being negative when the buffer arrived late and positive if it arrived in time. It also mentions that :

Using the jitter we can calculate the time when the buffer arrived in the

  T1 = B1 - J1.                                (1)

The time the buffer leaves the sink after synchronisation is measured as:

  T2 = B1 - (J1 < 0 ? J1 : 0)                  (2)

When Basesink code does it the other way around :

/* this is the time the buffer entered the sink */
entered = start + jitter;
/* this is the time the buffer left the sink */
left = start + (jitter < 0 ? 0 : jitter);
Comment 1 Wim Taymans 2006-08-11 13:12:03 UTC
        * docs/design/part-qos.txt:
        Bring docs in line with the code. Mostly the sign of the jitter was
        wrong in the docs. Fixes #349943.

        * gst/gstclock.c:
        Fix the docs for the jitter.

        * gst/gstevent.c: (gst_event_new_custom), (gst_event_new_tag),
        (gst_event_parse_tag), (gst_event_new_buffer_size),
        (gst_event_parse_buffer_size), (gst_event_parse_qos),
        (gst_event_new_seek), (gst_event_parse_seek),
        Make sure the GstStructure has no parent when creating custom
        Add some more argument checking so that we avoid 0.0 rates.
        Flesh out the docs for the QoS event some more.