GNOME Bugzilla – Bug 349758
gdm shouldn't clear error message when resetting after failed login
Last modified: 2006-08-03 17:25:12 UTC
At one point I changed gdm to have a GDM_SOP_CANCEL_LOGIN_REQUESTS feature to reset pam.
When adding this feature, I made the GDM_RESET operation more fully reset the graphical greeter. One such change was:
+ greeter_item_pam_error ("");
I think this was a mistake. It means that when the slave resets the greeter after a failed attemp, the pam error messages explaining why the problem failed gets erased.
Created attachment 70114 [details] [review]
don't immediately clear error message on login failure
Ray, I'm confused here. I don't see this change in GDM 2.14 or 2.15. I know you recently sent me some patches for review for SmartCard support, but I thought you were working more on those? The patch you provide doesn't seem to apply.
I do still need to do some smart card work, but this was to fix up a problem in the PAM reset patch, which I thought was already applied.
The PAM reset patch was a fairly independent prerequisite for the the smart card work.
The patch in attachment 70114 [details] [review] was against the rawhide tree, so I didn't notice that the pam-reset patch hasn't been applied yet.
What I'll do is fix up the pam-reset patch and resubmit it when I get a chance to finish up the smart card work
We can close this bug I guess. Sorry for the confusion.
Okay, that makes more sense. I look forward to reviewing your patch for SmartCard support - I think it will be a cool new feature. I assume that you'll just include this fix in that patch when you provide it.