After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349734 - followup quoting error (odd character in from header issue?)
followup quoting error (odd character in from header issue?)
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-08-03 00:20 UTC by Duncan
Modified: 2006-08-08 03:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0.106 patch to fix. (942 bytes, patch)
2006-08-08 03:56 UTC, Charles Kerr
none Details | Review

Description Duncan 2006-08-03 00:20:09 UTC
With pan 0.105:

There's a guy that posts semi-regularly to Cox's internal cox.* groups, that I can't properly reply to with pan.  I /think/ it's due to his choice of some odd characters in his "From" header, but haven't been able to duplicate it -- using the suspect characters in my own posts gives me a warning, but allows me to post, and followups to it work normally.

The followups come up /entirely/ blank -- no attribution, no quote, not even my sig, tho I can type into them and send as normal, and they show up in the right spot in the thread, so the references header must be coming thru intact.  A guess is that the characters cause the attribution to fail, which crashes the bit that inserts the quote and sig as well, thus the blank followup.  (It was investigating this that I found the previous bug I filed, that pan doesn't honor subject or group changes in the followup, when I tried to followup to the test group to see if I could figure out what was going on, and it ended up in the original group instead.)

Here's the from header (the problem would be the (R) and funny zeros in 2006):
From: Mag® 2ºº6 <studio.2_stop.spam_@_TheArtOfSound.strip_out.com>

Just as I'm posting this I notice something else:  After trying to post some messages with my own "funny zeros" to the test group... somewhere along the line, when I went back to grab the from header to paste it above, and hit "h" to expand the headers in pan, the line came up without the (r) and zeros, only Mag 26 and the email.  While the body pane was failing to display it correctly, the header pane was still displaying the full Mag® 2ºº6 in the author column.  Therefore, pan has /some/ problem dealing with it in any case, increasing the likelihood of that being what's triggering the blank followups.

My guess is that this isn't actually valid in what's supposed to be a 7-bit header.  In the worst case, however, pan should simply strip out the bad chars in the attribution (maybe popping up a warning to that effect, if it has to strip chars), handling the quote and attaching my chosen sig as normal.

If you have trouble duplicating, I can attach an entire post as it's stored in cache, but I'd prefer not to as these messages are posted to the cox-only groups.  I tried google groups but couldn't find anything, tho that could be due to my not working the search correctly.  However, I /do/ see a bunch of posts on google groups from someone named "Flyiñg Ñuñ 2°°6 +", which if I'm right could trigger the same issue.
Comment 1 Charles Kerr 2006-08-08 02:49:59 UTC
No need to attach the post, I have access to the cox newsgroups and found
one of his in cox.internet.discussion.newsgroups dated last Tuesday.

Confirmed, I'm seeing the same behavior.

In the console, when pressing Follow-Up: 

(pan:4603): Gtk-CRITICAL **: gtk_text_buffer_emit_insert: assertion `g_utf8_validate (text, len, NULL)' failed
(21:40:46)(charles localhost)(~): cd src/pan-devel
(pan:4603): Gtk-CRITICAL **: gtk_text_buffer_emit_insert: assertion `g_utf8_validate (text, len, NULL)' failed
Comment 2 Charles Kerr 2006-08-08 03:56:11 UTC
Created attachment 70444 [details] [review]
0.106 patch to fix.