Bug 349349 - Bookmarks search entry width
Bookmarks search entry width
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-07-30 21:22 UTC by Wouter Bolsterlee (uws)
Modified: 2006-10-15 14:03 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
Small search bar (current status) (20.26 KB, image/png)
2006-07-30 21:22 UTC, Wouter Bolsterlee (uws)
  Details
Large search bar (proposal) (18.62 KB, image/png)
2006-07-30 21:24 UTC, Wouter Bolsterlee (uws)
  Details
Makes the bme look like the proposed mockup (629 bytes, patch)
2006-08-15 09:48 UTC, Diego Escalante Urrelo (not reading bugmail)
accepted-commit_after_freeze Details | Diff | Review

Description Wouter Bolsterlee (uws) 2006-07-30 21:22:00 UTC
The bookmark search entry matches both topic and bookmark names, but the UI implies only the bookmarks are searched through. The UI should be updated to reflect what the application does. I'll attach two screenshots.
Comment 1 Wouter Bolsterlee (uws) 2006-07-30 21:22:38 UTC
Created attachment 69928 [details]
Small search bar (current status)

This is how it looks now.
Comment 2 Wouter Bolsterlee (uws) 2006-07-30 21:24:45 UTC
Created attachment 69929 [details]
Large search bar (proposal)

This is how it should look to reflect what the application really does.
Comment 3 Reinout van Schouwen 2006-07-30 22:40:13 UTC
Maybe it could be on the bottom, to maintain consistency with the browser find bar?
Comment 4 Wouter Bolsterlee (uws) 2006-07-31 07:16:58 UTC
In that case it should be hidden by default and only popup on ctrl-f. I think that's not the right way to go, since the search/filter is one of the most common ways to quickly find a bookmark.

In my opinion the entry is more like a location bar than a search bar, despite it's name ;)
Comment 5 Reinout van Schouwen 2006-08-01 07:15:30 UTC
The search function in the bookmarks window is much more prominent than it is in the browser window. Therefore it makes no sense to hide it by default. 

On second thought, the search field on top is not so bad, because we want to encourage users to use it. I'd like to hear mpt's opinion on this though.
Comment 6 Wouter Bolsterlee (uws) 2006-08-02 12:03:04 UTC
chpe, any chance to get this tiny "ui freeze breakage" in for 2.16?
Comment 7 Christian Persch 2006-08-02 12:06:03 UTC
Not without a patch :)
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2006-08-15 09:48:14 UTC
Created attachment 70925 [details] [review]
Makes the bme look like the proposed mockup

Just changes a line for the magic to happen.
Comment 9 Wouter Bolsterlee (uws) 2006-08-15 09:58:04 UTC
Confirming this works as proposed. chpe, mind if I commit?
Comment 10 Christian Persch 2006-09-03 12:58:24 UTC
To HEAD only.
Comment 11 Wouter Bolsterlee (uws) 2006-10-15 14:03:45 UTC
2006-10-15  Wouter Bolsterlee  <wbolster@gnome.org>

    * src/bookmarks/ephy-bookmarks-editor.c:
    (ephy_bookmarks_editor_construct):
    Use full width for bookmarks search bar.
    Fixes bug #349349, patch by Diego Escalante Urrelo.

Note You need to log in before you can comment on or make changes to this bug.