After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349274 - Help kill libegg
Help kill libegg
Status: RESOLVED WONTFIX
Product: netapplet
Classification: Deprecated
Component: applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Robert Love
Robert Love
gnome[unmaintained]
Depends on:
Blocks: 339241 349256
 
 
Reported: 2006-07-30 10:59 UTC by Vincent Untz
Modified: 2012-02-28 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ports from Egg*Icon to GtkStatusIcon (5.50 KB, patch)
2006-11-21 05:51 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
Same as before, but with a check to avoid ugly icons (5.71 KB, patch)
2006-11-21 06:39 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
Assumes that users have standard 24 pixel panels (5.80 KB, patch)
2006-11-21 07:50 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review

Description Vincent Untz 2006-07-30 10:59:52 UTC
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2006-11-21 05:19:32 UTC
I'm working on porting from EggTrayIcon/EggStatusIcon to GtkStatusIcon. So far I have made good progress.

This comments is just to avoid duplicated work.

Read ya
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2006-11-21 05:51:06 UTC
Created attachment 76961 [details] [review]
Ports from Egg*Icon to GtkStatusIcon

This works almost flawlessly, only glitch is that when you open this for the first time and wireless is enabled AND without signal, the wireless-0 icon will be ugly and badly sized, I think it's a matter of adding a call somewhere, easy to fix. 
But I wanted to hear impressions about this patch so far.

Greetings :)
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2006-11-21 06:39:43 UTC
Created attachment 76963 [details] [review]
Same as before, but with a check to avoid ugly icons

This patch is the same as the first, but it doesn't display the icon until it's sure that the GtkStatusIcon is already shown (so the size of the tray is known and our icon looks good).
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2006-11-21 07:50:34 UTC
Created attachment 76965 [details] [review]
Assumes that users have standard 24 pixel panels

Previous patch won't show an icon if the user is using an ethernet connection, since the first time the GtkStatusIcon is not embedded (and the ethernet connection will never call netapplet_set_icon).

I think this is a sane default, I reported a bug about this against GTK+ #377674. Let's see what GTK+ devs say.

Meanwhile this works great (both with wlan and eth).
Comment 5 André Klapper 2009-08-04 14:24:42 UTC
Diego, can this get in?
Hmm, where is this in git?
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2009-08-08 16:21:08 UTC
I'll check it today.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2009-08-08 16:30:40 UTC
Ehm. I don't find the repo in git...
Comment 8 André Klapper 2012-02-28 20:18:25 UTC
Netapplet has not seen any development (code changes) since May 2005 - see http://git.gnome.org/browse/archive/netapplet/log/ .
Closing all remaining open reports as WONTFIX - Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.