After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349261 - Help kill libegg
Help kill libegg
Status: RESOLVED FIXED
Product: criawips
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Criawips maintainers
Criawips maintainers
Depends on:
Blocks: 349256
 
 
Reported: 2006-07-30 10:37 UTC by Vincent Untz
Modified: 2006-11-18 12:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use gtk+ 2.10 recent files support (16.29 KB, patch)
2006-11-17 23:01 UTC, Jan Arne Petersen
none Details | Review
Use gtk+ 2.10 recent files support (Fixed coding style) (14.90 KB, patch)
2006-11-18 11:20 UTC, Jan Arne Petersen
accepted-commit_now Details | Review

Description Vincent Untz 2006-07-30 10:37:11 UTC
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 Jan Arne Petersen 2006-11-17 23:01:42 UTC
Created attachment 76783 [details] [review]
Use gtk+ 2.10 recent files support
Comment 2 Sven Herzberg 2006-11-17 23:19:23 UTC
Looks nice except for these glitches (already mentioned on Jabber, just keeping them over here):

cria-main-window.c:99: das sternchen ist inkonsistent plaziert
105: ditto
447: indentation des '=' zeichens
998: bitte einen doppelpunkt an das FIXME: setzen
Comment 3 Jan Arne Petersen 2006-11-18 11:20:52 UTC
Created attachment 76804 [details] [review]
Use gtk+ 2.10 recent files support (Fixed coding style)
Comment 4 Jan Arne Petersen 2006-11-18 12:03:54 UTC
2006-11-18  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* configure.in:
	* copy-src/Makefile.am:
	* copy-src/recent-files:
	* doc/reference/Makefile.am:
	* src/Makefile.am: remove egg recent files support

	* data/criawips.desktop.in: fix exec line

	* src/application.c:
	* src/application.h:
	* src/dom/cria-presentation.c: replace cria_application_add_to_recent
	with cria_main_window_add_to_recent
	* data/criawips.ui:
	* src/widgets/cria-main-window.c: use gtk+ 2.10 recent files support