After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349109 - Add magic image scaling
Add magic image scaling
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other All
: Normal enhancement
: Yelp 3.0
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-28 17:08 UTC by Shaun McCance
Modified: 2011-01-04 00:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (232.40 KB, image/png)
2011-01-03 02:53 UTC, Jean-François Fortin Tam
Details

Description Shaun McCance 2006-07-28 17:08:26 UTC
When images are too wide for the screen, Yelp should scale them to fit and include a button to expand them to full size.  This will require some JavaScript trickery. 

Ideally, we should see if there are options in Gecko for what kind of interpolation to use for scaling.  Given the low number of images we expect to deal with in a given help page, we can probably afford to use high-quality scaling.
Comment 1 Joachim Noreiko 2006-07-29 16:07:24 UTC
How should the expanded image appear?
If it is simply within the Yelp content pane, the user may well have to scroll horizontally to see all of it, which is not good.

Is it possible to pop-up the image like a sort of giant tooltip? 
If so, should this only appear while the click is held down (bad for accessibility), have a close button (annoying if used many times), or be dismissed by clicking anywhere on it (which I think is best)?
I don't know what is feasible. It might also be an idea to run this past the usability list for their thoughts.
Comment 2 Karderio 2006-08-03 10:11:54 UTC
Perhaps having to scroll isn't too bad, as the user already has the full image scaled down. Also, if the image needs scaling in yelp, it may well need scaling in the popup too, with yelp maximised that is.

Anyhow, all this is just because I'm a bit scared of popups - feel free to ignore me ;)

Love, Karderio.
Comment 3 Jean-François Fortin Tam 2010-09-26 16:27:40 UTC
How about fixing this for 3.0? Yelp doesn't even use Gecko anymore, if I'm not mistaken.

It should at least allow the "figure" border to be a flexible width so that it expands with images.
Comment 4 Jean-François Fortin Tam 2011-01-03 02:53:10 UTC
Created attachment 177388 [details]
screenshot

This illustrates the problem.

Yelp uses webkit now. Why not simply set a css property on images? For example if the image legend/frame is 500px wide, have the following css on the image:

width:500px;
height:auto;
Comment 5 Shaun McCance 2011-01-04 00:24:19 UTC
Implemented in yelp-xsl master. Images in figures are automatically scaled with the window size, and there's a button to expand them to full size. It only works in figures (in Mallard or Docbook) because it provides a convenient place to put a zoom button.