After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349072 - No artwork for Greenday's Internal Superhits
No artwork for Greenday's Internal Superhits
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 412853
 
 
Reported: 2006-07-28 11:15 UTC by Bastien Nocera
Modified: 2007-03-03 04:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for 'argument 4 impossible' error (928 bytes, patch)
2006-08-02 12:44 UTC, Jonathan Matthew
committed Details | Review

Description Bastien Nocera 2006-07-28 11:15:11 UTC
It might be a problem with the search
title: Stuck With Me
artist: Green Day
album: International Superhits!
(with the exclamation mark at the end)
Comment 1 Luís Ferreira 2006-08-02 10:24:16 UTC
I'm using RB from CVS(checked out 06/08/01) on a debian sid system.

I don't have that specific album but... i do have a lot of "problems" with the art plugin.

For ex the following never had covers:

Album: Future Sounds of Jazz - Vol.01
until  Future Sounds of Jazz - Vol.10
Various Artists.

Album: Cafe Del Mar - Vol.01
until  Cafe Del Mar - Vol.12
Various Artists

Album: The Rough Guide To Bhangra
       The Rough Guide To Scottish Music
Various Artists

A LOT more, not all of them various artists, for example... Mezzanine from Massive Attack doesn't get a cover also.

I think the plugin doesnt even try to download anything now, the last cover it downloaded was on 06-07-16 since then it shows the covers that alredy exists and the ones he should try to find/download i just get the following error on ~/.xsession-errors:

Traceback (most recent call last):
  • File "/usr/lib/rhythmbox/plugins/artdisplay/__init__.py", line 71 in playing_changed
    self.set_entry(sp.get_playing_entry ())
  • File "/usr/lib/rhythmbox/plugins/artdisplay/__init__.py", line 101 in set_entry
    self.art_db.get_pixbuf(db, entry, self.on_get_pixbuf_completed)
  • File "/usr/lib/rhythmbox/plugins/artdisplay/CoverArtDatabase.py", line 66 in get_pixbuf
    rb.Coroutine (self.image_search, db, st_album, st_artist, entry, callback).begin ()
  • File "/usr/share/rhythmbox/plugins/rb/Coroutine.py", line 49 in begin
    self._resume ()
  • File "/usr/share/rhythmbox/plugins/rb/Coroutine.py", line 38 in _resume
    self._continuation.next ()
  • File "/usr/lib/rhythmbox/plugins/artdisplay/CoverArtDatabase.py", line 81 in image_search
    engine.search (db, entry, plexer.send ())
  • File "/usr/lib/rhythmbox/plugins/artdisplay/LocalCoverArtSearch.py", line 51 in search
    gnomevfs.async.load_directory (self.uri.parent, self._load_dir_cb, LOAD_DIRECTORY_FLAGS, data=([], on_search_completed_cb, entry, args))
TypeError: gnomevfs.async.load_directory() argument 4 impossible<bad format char>

Comment 2 Luís Ferreira 2006-08-02 10:29:00 UTC
Ohh when it doesn't found a cover it keeps showing the last cover it found.
Maybe a generic cover for unfound/unknow artists.
Comment 3 Jonathan Matthew 2006-08-02 12:44:57 UTC
Created attachment 70070 [details] [review]
patch for 'argument 4 impossible' error

This isn't the same issue as initially reported, but here's a patch anyway.
Comment 4 Luís Ferreira 2006-08-02 15:32:28 UTC
Thanks :)
That fixed the errors, the plugin is working again and downloading covers.

From what i've been able to see it still doesn't download covers of albums that include vol on their name, like:
Future Sounds of Jazz - Vol.01
Cafe Del Mar - Vol.01

It has the same problem with CD in the name of the album, after i removed all the CD1, CD2, etc from my album tags(only recently i started to use the cd number tag) it found every cover.
I only mention this because i think AmazonCoverArtSearch.py has code to remove that(and vol also).

# Remove variants of Disc/CD [1-9] from album title before search
for exp in ["\([Dd]isc *[1-9]+\)", "\([Cc][Dd] *[1-9]+\)"]:
p = re.compile (exp)
st_album = p.sub ('', st_album)
Comment 5 Jonathan Matthew 2006-08-05 03:08:45 UTC
I've committed the patch to CVS.
Comment 6 Luís Ferreira 2006-08-20 09:28:10 UTC
I'm using CVS from 06/08/18 and tagged some file to Stuck With Me by Green Day from International Superhits! and it found the right cover. So it seems this is fixed.
Comment 7 James "Doc" Livingston 2007-03-03 04:53:54 UTC
Marking fixes as per previous comment