GNOME Bugzilla – Bug 348989
Make use of view-fullscreen icon
Last modified: 2006-11-01 10:42:55 UTC
There is (at least now in 2.15.x) a view-fullscreen icon that would better fit the "Fullscreen" menu entry.
Created attachment 69766 [details] [review] Patch against HEAD This is for use with g-i-t 2.15.x and uses the new icon naming scheme.
Created attachment 69769 [details] [review] Additional icons This converts all icons (from totem.glade) that have a matching name in the icon spec to the new name. Works nice with g-i-t 2.15.x and tango. This now uses different icons for volume up and down.
This would mean stopping using the gtk+ stock icons for a lot of those, which I'm not happy with. Most of the icons should fallback back nicely already, and I'd like the "view-fullscreen" to use the framework in totem-stock-icons.c
Created attachment 71666 [details] [review] Patch against HEAD, 2nd Try Well, yesterday I had to play a few movies and I remember filing this bug. Seeing that it is still open and the 2.16 release just around the corner I had a look myself. I *think* this is what you want, but that produced horrible scaling, because the menu icons are set to use those icons in size of GTK_ICON_SIZE_BUTTON. This is bad so I changed to GTK_ICON_SIZE_MENU. It may be needed to case this for menu/button icons but at least here I can't see a difference on the exit fullscreen button, it uses the 16x16 icon in both cases. Take screenshot and fullscreen really look better this way though.
This was all fixed in #357143. Thanks for the patches though. *** This bug has been marked as a duplicate of 357143 ***