After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348636 - Help kill libegg
Help kill libegg
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks: 349256
 
 
Reported: 2006-07-25 13:16 UTC by Vincent Untz
Modified: 2008-03-20 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.82 KB, patch)
2006-07-25 13:17 UTC, Vincent Untz 		needs-work Details | Review

Description Vincent Untz 2006-07-25 13:16:59 UTC 
The following patch replaces the use of eggaccelerators and eggcellrendererkeys by the new stuff in GTK+.

It nearly works: looks like editing of the shortcuts is broken, but I can't figure out why now.

When committing, the egg files from CVS should also be removed. Oh, and a check for GTK+ 2.10 should probably be added in configure.in.
Comment 1 Vincent Untz 2006-07-25 13:17:36 UTC 
Created attachment 69575 [details] [review]
patch
Comment 2 Daniel Macks 2006-07-25 16:07:13 UTC 
Nothing "probably" about the "should" IMO. If you're going to use a gtk2.10 feature, it's quite important to check for gtk2.10. Otherwise users with gtk2.8 will get complicated compiler error messages that everyone wastes time diagnosing instead of a clean "your gtk is not >= 2.10".
Comment 3 Vincent Untz 2006-07-25 17:17:51 UTC 
I wrote "probably" because the check might already be there :-)
Comment 4 Guilherme de Siqueira Pastore 2006-07-28 21:37:00 UTC 
And I thought there would be something to complain about the "nearly works", but not about the "probably"... strange world.
Comment 5 Guilherme de Siqueira Pastore 2006-07-29 14:35:43 UTC 
err, someone, not something, obviously
Comment 6 Christian Persch 2008-03-20 15:02:48 UTC 
Should be fixed in svn trunk.