After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348445 - Can't select multiple groups
Can't select multiple groups
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Windows
: Low enhancement
: 1.0
Assigned To: Charles Kerr
Pan QA Team
: 348951 350123 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-23 20:15 UTC by Artur Jachacy
Modified: 2007-05-09 03:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0.115 patch (2.67 KB, patch)
2006-10-02 18:51 UTC, Charles Kerr
committed Details | Review

Description Artur Jachacy 2006-07-23 20:15:26 UTC
Pan is missing the ability to select multiple groups at once. It would be very useful e.g. when subscribing several groups or changing their properties.
Comment 1 Charles Kerr 2006-07-25 22:56:48 UTC
The work-to-benefit ratio on this is pretty high IMO.
Comment 2 Jeff Berman 2006-07-25 23:12:42 UTC
Understanding that it's a difficult change and that it may never get implemented, please allow me to second and third this request.
Comment 3 Charles Kerr 2006-07-25 23:52:14 UTC
:)
Comment 4 Duncan 2006-07-26 15:01:22 UTC
0.104 observation:  If this isn't going to make it into 1.0, "Get new headers for selected groups" needs a slight tweak. =8^)

Obvious: s/groups/group/

Maybe: s/selected/active/
Comment 5 Christophe Lambin 2006-07-26 16:59:50 UTC
*** Bug 348741 has been marked as a duplicate of this bug. ***
Comment 6 Charles Kerr 2006-07-27 19:15:42 UTC
Duncan: agree with s/groups/group/

However selected != active... IMO a user might interpret 'active'
as being 'the group being shown in the header pane'
Comment 7 Charles Kerr 2006-07-27 20:09:53 UTC
*** Bug 348951 has been marked as a duplicate of this bug. ***
Comment 8 devchan1 2006-07-30 00:28:23 UTC
I am going to vote for this bug.
Comment 9 Matt 2006-07-30 15:22:42 UTC
I vote for this one too. Thanks!
Comment 10 Miguel 2006-07-30 17:10:14 UTC
I vote for this feature.
Comment 11 alen_williams 2006-07-30 17:11:29 UTC
Yeah, me three votes for this!
Comment 12 Charles Kerr 2006-08-07 16:16:25 UTC
*** Bug 350123 has been marked as a duplicate of this bug. ***
Comment 13 Phil Richards 2006-09-06 21:31:44 UTC
There is another side effect of this, as far as I can see.  I can't choose to "mark group read" across multiple groups at the same time.  This is *incredibly* annoying - I subscribe to 20 or 30 news groups.  Some I always read, others I read when I get a chance.  With the 0.100+ versions I have to individually select each group to "mark as read" - I can't just "catch up" everything in one go.  (Or if I can, it's somewhat hidden.)

Perhaps (just for this case) the "Subscribed groups" node in the group list could have its own menu which included "mark all as read"?
Comment 14 Charles Kerr 2006-10-02 18:51:14 UTC
Created attachment 73882 [details] [review]
0.115 patch

This patch doesn't enable multiple group selection.  It only
applies Duncan's suggestion in comment #4 about the misleading
syntax of `Selected Groups' in the menus.
Comment 15 John Aldrich 2006-11-03 12:35:27 UTC
Please consider this a vote for this bug. It would be GREATLY appreciated by this Pan user if you could work on this post-1.0. I realize that you've pretty much frozen features for pre-1.0 and are just working on squashing bugs, so I know this bug is pretty much going to be ignored, at least until post-1.0 release. :-)
Comment 16 Charles Kerr 2006-11-03 19:54:14 UTC
*sigh* that's, what, ten votes for this feature?

Marking as assigned, flagging for 1.1.
Comment 17 Keith 2006-11-10 01:36:15 UTC
(In reply to comment #16)
> *sigh* that's, what, ten votes for this feature?
> 
> Marking as assigned, flagging for 1.1.
> 

Charles:
  Just a quick note to agree with the ten others and that a way to multiply select groups would be great.  Thanks to you all for a great job so far!
  BTW, I am using Pan 0.18 on Mandriva Linux 2007 and it's great!  :-)

Keith
Comment 18 Jack Ostroff 2007-01-15 00:44:50 UTC
I don't know if further votes make any difference since it's already been assigned, but I'm also for fixing it.  (I'm on Gentoo Linux, if it matters.)
Comment 19 Mel 2007-05-05 22:01:20 UTC
I don't understand why it was taken out in the first place. Any list that does not stipulate one selection only needsd multiple selection. Control or shift depending on the type of selection is standard practice and not something you would expect to be dropped. I now have to mess around with Ubuntu to install an old version that works correctly and force Ubuntu not to update it. What a pain.
Comment 20 Duncan 2007-05-05 23:26:09 UTC
(In reply to comment #19)
> I don't understand why it was taken out in the first place.

It wasn't exactly taken out.  New-pan (0.90+) is a ground-up rewrite, new language (C++, old was C), new code.  The feature simply hasn't been coded back into the rewrite yet.  

There are apparently some problems with the way the GTK widget works that make adding multi-select "non-trivial", as Charles says.  It may be that a different widget will need to be chosen and the code rejiggered to work with it.  Either that, or the deficiencies of the current widget will have to be "manually" coded around.

FWIW, Charles has always been quite open to patches.  As he has made it plain he's not looking forward to working on this, and as from your comment it appears you believe it to be trivial, if you could code up a patch adding the functionality without killing anything else, I'm sure he'd love to see it. =8^)  I know I would, as I miss the functionality too, but unfortunately I'm not a coder much beyond bash. =8^(

Duncan
Comment 21 Charles Kerr 2007-05-06 16:16:43 UTC
Checked in in svn revision 263.
Comment 22 Duncan 2007-05-06 17:44:39 UTC
Happy happy, joy joy! =8^)  Thanks!

Duncan
Comment 23 Mel 2007-05-06 21:35:28 UTC
I don't actually know what 'Checked in in svn revision 263' means but I'll assume it's good judging by Duncan's reaction. I'll hazzard a guess and say it's been resolved and will permiate to the stable version in due course?
If so cool and thank you Charles.
Comment 24 Charles Kerr 2007-05-07 00:11:09 UTC
It's in 0.129, which was released earlier today. :)
Comment 25 Darren Albers 2007-05-07 17:25:58 UTC
Great patch Charles, though the string might need to be changed back to being groups again.   ;-)
Comment 26 Charles Kerr 2007-05-09 03:05:13 UTC
Done, thanks.  =)