GNOME Bugzilla – Bug 348435
Lockdown support for background capplet
Last modified: 2021-06-09 16:02:11 UTC
This patch is very similar to the one me and Thomas have been working on for the theme switcher. No rush since the support won't be added to pessulus until post-2.16.
Created attachment 69429 [details] [review] Initial patch for lockdown support
The capplet already supports lockdown by disabling the user to write to individual keys.
Rodney, I've reopened this bug since I think that the current solution can be improved upon: (1) You don't give any feedback to the user. The HIG says you should do that. http://developer.gnome.org/projects/gup/hig/1.0/controls.html#controls-locked (2) This isn't the way its done everywhere else in the desktop. (3) This makes it very hard to integrate with Pessulus, we have a 1-1 mapping between a key and an option. We also intend to use the description. This makes the maintenance manageable. Cheers, Rob
The mapping isn't 1:1. There are multiple options within the background capplet. Currently each one of those can be locked down individually. The addition of this patch would mean that we have multiple lockdown solutions. We really only need to have ONE across the desktop. I don't see any rason to change this now. Is there an official "this is the ONE way to do it" announcement? I haven't seen any. I'm rejecting this patch for now. If the way to do lockdown gets cleared up, and a patch that only does it that one way, is presented, then we can get that in.
This is still broken in the new panel. Locking down the individual keys in dconf results in absolutely no feedback in the panel. The panel actually allows you to move the selection to a different background -- and simply nothing happens. It should grey out and give a description of why (or something?).
I agree with desrt. gnome-control-center should recognize that the background key is locked and change the Background panel accordingly. I think it should also be smart enough to tell if the user is an admin user and adjust based on whether the user likely has the ability to break the lock or not.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.