After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347756 - Allow --disable-trace without --disable-parse
Allow --disable-trace without --disable-parse
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
Other All
: Normal minor
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on: 342564
Reported: 2006-07-17 10:40 UTC by Peter Kjellerstedt
Modified: 2006-07-18 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Adds missing defines to gsttrace.h (946 bytes, patch)
2006-07-17 10:41 UTC, Peter Kjellerstedt
none Details | Review
Allow --disable-trace to be used correctly (3.56 KB, patch)
2006-07-17 12:14 UTC, Peter Kjellerstedt
committed Details | Review

Description Peter Kjellerstedt 2006-07-17 10:40:39 UTC
Please describe the problem:
The attached patch adds two missing defines to gsttrace.h when tracing is disabled.  It also corrects one existing define.

Steps to reproduce:
Configure with --disable-trace and --disable-alloc-trace, but not with --disable-parse.

Actual results:
Compilation of gst-launch will fail.

Expected results:

Does this happen every time?

Other information:
Comment 1 Peter Kjellerstedt 2006-07-17 10:41:24 UTC
Created attachment 69031 [details] [review]
Adds missing defines to gsttrace.h
Comment 2 Peter Kjellerstedt 2006-07-17 12:13:17 UTC
Argh, of course there was more to this than I first noticed.

The patch applied to gstreamer/gst/ in revision 1.215, taken from bug #344016, prevents gsttrace.h from being installed if --disable-trace is used. However, I belive this is incorrect. The reason is that this file seem to be made so that it should always be installed, as the functions related to alloc-trace have empty defines if their functionality is disabled. More so, the main gst.h file include gsttrace.h unconditionally, which causes compilation of gst-plugins-base to fail if --disable-trace has been used...

The correct fix for bug #344016 is instead to unconditionally define the types and enums related to tracing in gsttrace.h.

I have attached a new patch which should revert the previous patch to, and instead do the right thing in gsttrace.h.
Comment 3 Peter Kjellerstedt 2006-07-17 12:14:27 UTC
Created attachment 69036 [details] [review]
Allow --disable-trace to be used correctly
Comment 4 Wim Taymans 2006-07-18 09:43:04 UTC
        Patch by: Peter Kjellerstedt <pkj at axis dot com>

        * gst/
        * gst/gsttrace.h:
        The attached patch adds two missing defines to gsttrace.h when tracing
        is disabled.  It also corrects one existing define.
        Fixes #347756.