GNOME Bugzilla – Bug 347756
Allow --disable-trace without --disable-parse
Last modified: 2006-07-18 09:43:25 UTC
Please describe the problem:
The attached patch adds two missing defines to gsttrace.h when tracing is disabled. It also corrects one existing define.
Steps to reproduce:
Configure with --disable-trace and --disable-alloc-trace, but not with --disable-parse.
Compilation of gst-launch will fail.
Does this happen every time?
Created attachment 69031 [details] [review]
Adds missing defines to gsttrace.h
Argh, of course there was more to this than I first noticed.
The patch applied to gstreamer/gst/Makefile.am in revision 1.215, taken from bug #344016, prevents gsttrace.h from being installed if --disable-trace is used. However, I belive this is incorrect. The reason is that this file seem to be made so that it should always be installed, as the functions related to alloc-trace have empty defines if their functionality is disabled. More so, the main gst.h file include gsttrace.h unconditionally, which causes compilation of gst-plugins-base to fail if --disable-trace has been used...
The correct fix for bug #344016 is instead to unconditionally define the types and enums related to tracing in gsttrace.h.
I have attached a new patch which should revert the previous patch to Makefile.am, and instead do the right thing in gsttrace.h.
Created attachment 69036 [details] [review]
Allow --disable-trace to be used correctly
Patch by: Peter Kjellerstedt <pkj at axis dot com>
The attached patch adds two missing defines to gsttrace.h when tracing
is disabled. It also corrects one existing define.