Bug 347022 - ephy-window key_press_event handler eats key-presses without handling them
ephy-window key_press_event handler eats key-presses without handling them
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
2.14.x
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-07-09 08:52 UTC by Christian Neumair
Modified: 2006-07-10 19:28 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neumair 2006-07-09 08:52:14 UTC 
I'm trying to add code like the extra_keybinding handler from Ephy (ephy-window.c) to Nautilus, and I noted that Ephy returns TRUE even if gtk_action_activate fails because the action isn't sensitive. Maybe code like

if (gtk_action_is_sensitive (action)) {
  gtk_action_activate (action);
  return TRUE;
}

would be better?
Comment 1 Christian Persch 2006-07-10 19:28:53 UTC 
I fixed this in cvs (HEAD and gnome-14). Thanks for the bug report!
Note You need to log in before you can comment on or make changes to this bug.