After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346977 - [PATCH] Switch to GMCS
[PATCH] Switch to GMCS
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 337724 346338
 
 
Reported: 2006-07-08 12:06 UTC by Ruben Vermeersch
Modified: 2006-10-31 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.16 KB, patch)
2006-07-08 12:07 UTC, Ruben Vermeersch 		reviewed Details | Review
updated patch (3.82 KB, patch)
2006-09-26 10:12 UTC, Stephane Delcroix 		committed Details | Review

Description Ruben Vermeersch 2006-07-08 12:06:43 UTC 
Attached patch switches f-spot to use gmcs.

I am working to share the database layer used by f-spot and banshee (to reduce duplicate code). As banshee uses generics (and generics are the way of the future), f-spot had to be compiled using gmcs too.

The new compiler also shows a lot of unused cruft, should be a nobrainer to clean that up afterwards.
Comment 1 Ruben Vermeersch 2006-07-08 12:07:17 UTC 
Created attachment 68619 [details] [review]
patch

 FlickrNet/Makefile.am        |    2 +-
 configure.in                 |    4 ++--
 libgphoto2-sharp/Makefile.am |    2 +-
 semweb/Makefile.am           |    2 +-
 src/Makefile.am              |    2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
Comment 2 Aaron Bockover 2006-07-10 18:37:31 UTC 
I brought up moving to gmcs/2.0 to Larry a couple of weeks ago. As I think Banshee and MonoDevelop have shown, it's completely usable and provides an awesome set of new language/runtime features we can take full advantage of now.

This build system patch works fine for me. The next step would be ideally cleaning up all the new issues the gmcs compiler exposes in the code that mcs doesn't care about.
Comment 3 Stephane Delcroix 2006-09-26 10:12:35 UTC 
Created attachment 73418 [details] [review]
updated patch

Updated patch to switch also google-sharp and gnome-keyring-sharp
Comment 4 Stephane Delcroix 2006-09-29 07:48:55 UTC 
Larry committed a patch to switch the compilation of src/ with mcs, but it's not complete yet.
Comment 5 Stephane Delcroix 2006-10-31 13:19:43 UTC 
Committed to CVS, fixing also bug #358247. The reason to commit is to no longer depends on both mcs and gmcs.