After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346916 - Tact numbers in TrackRoll view wrong
Tact numbers in TrackRoll view wrong
Status: RESOLVED FIXED
Product: beast
Classification: Other
Component: beast-gtk
SVN trunk
Other Linux
: Normal normal
: ---
Assigned To: Beast Maintainers
Beast Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-07 15:54 UTC by Stefan Westerfeld
Modified: 2006-10-22 00:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch which fixes tact numbers in track roll view (1.22 KB, patch)
2006-07-07 15:55 UTC, Stefan Westerfeld 		none Details | Review

Description Stefan Westerfeld 2006-07-07 15:54:58 UTC 
The tact numbers in track roll view should be simply counted, like 1 2 3 4 5 and so on (there are no :2 tacts). I'll attach a patch which fixes this.
Comment 1 Stefan Westerfeld 2006-07-07 15:55:53 UTC 
Created attachment 68573 [details] [review]
Patch which fixes tact numbers in track roll view
Comment 2 Tim Janik 2006-10-21 21:41:38 UTC 
the current tact handling is a mess in places and a candidate for an overall rewrite.
until that happens, your patch is probably going to produce less confusion than the current code, so fine to apply. 
that is, provided you're writing a proper ChangeLog entry which the patch is missing.
Comment 3 Stefan Westerfeld 2006-10-22 00:06:20 UTC 
Ok, I committed the patch now, the corresponding ChangeLog entry is:

Sun Oct 22 01:54:54 2006  Stefan Westerfeld  <stefan@space.twc.de>

        * beast-gtk/bsttrackroll.c: Fix tact numbers in TrackRoll view,
        fixes bug #346916. Instead of printing (more or less) useless
        numbers, the tacts in the TrackRoll view are now numbered 1 2 3 4 and
        so on, and only every fourth of these numbers is shown if there is not
        enough screenspace. This change only works for 4/4 tacts, so this is a
        temporary fix, until the tact handling of beast is rewritten.