After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346881 - Remove redundant title of tab and move menu button up
Remove redundant title of tab and move menu button up
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.2.x
Other All
: High enhancement
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on: 116650
Blocks: 346891
 
 
Reported: 2006-07-07 13:04 UTC by Roman Frołow
Modified: 2010-06-18 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mockup of removed tittle from tab. (27.06 KB, image/png)
2006-07-07 13:05 UTC, Roman Frołow
  Details
0001-app-Remove-the-drag-handle-and-use-tabs-exclusively.patch (42.06 KB, patch)
2010-02-01 18:36 UTC, Martin Nordholts
none Details | Review
/0001-app-Remove-the-drag-handle-from-dockables-and-use-ta.patch (44.49 KB, patch)
2010-02-03 06:53 UTC, Martin Nordholts
committed Details | Review

Description Roman Frołow 2006-07-07 13:04:41 UTC
Title of tab inside tab should be removed. Tab will take less space than. Look at attached mock-up.

Other information:
Comment 1 Roman Frołow 2006-07-07 13:05:53 UTC
Created attachment 68558 [details]
Mockup of removed tittle from tab.
Comment 2 Sven Neumann 2006-07-07 14:54:25 UTC
We need to put the menu button somewhere and GTK+ doesn't allow us to put it where you put it in your mockup. Sorry, but your suggestion is not implementable.
Comment 3 Raphaël Quinet 2006-07-07 18:13:22 UTC
I'd like to re-open this bug because even if GTK+ does not make it easy, it is still possible to have a button added to the right of the tabs (like e.g. in Firefox).  But maybe this should depend on a new bug report to be submitted against GTK+?

I would really like to save the vertical space that is currently taken by this button (and the tab name / title).
Comment 4 Martin Nordholts 2009-11-09 06:51:58 UTC
With GtkNotebook now supporting this it would be incredibly nice to get this into 2.8. From what I've heard GTK+ 2.20 is soon to be out, and with quite a lot of things left to do on 2.8 we might be able to depend on GTK+ 2.20 for GIMP 2.8. Setting milestone to 2.8.
Comment 5 Martin Nordholts 2010-02-01 18:36:15 UTC
Created attachment 152751 [details] [review]
0001-app-Remove-the-drag-handle-and-use-tabs-exclusively.patch

Here's a straigtforward patch using GTK 2.20 API, probably needs some further work. I'll start a thread on gimp-developer.
Comment 6 Martin Nordholts 2010-02-03 06:53:22 UTC
Created attachment 152905 [details] [review]
/0001-app-Remove-the-drag-handle-from-dockables-and-use-ta.patch

Same as before but also make the Tab Style meny appear in dockbooks with only one tab.
Comment 7 Martin Nordholts 2010-02-04 07:33:51 UTC
Link to thread:
http://lists.xcf.berkeley.edu/lists/gimp-developer/2010-February/024120.html

Conclusion:
Add new tab style "Automatic" and make it default. If it works well, commit when we can depend on GTK 2.20.
Comment 8 Martin Nordholts 2010-06-11 23:22:51 UTC
There we go, first

commit 9b86acd16bc50cd22ac7b7defaab4e3eee78039d
Author: Martin Nordholts <martinn@src.gnome.org>
Date:   Fri Jun 11 23:18:49 2010 +0200

    Add 'Automatic' Tab Style support
    
    Add support for a new type of Tab Style called 'Automatic'. This tab
    style makes the GimpDockbook use the biggest actual tab style it can
    for its auto tab style dockables, based on its widget allocation.
    
    The tab style candidates for auto tab style are "Status + Blurb",
    "Status + Text" and "Status". A docked widget can also say that it
    wants to use "Icon" instead of "Status" for its auto tab style. The
    'Tool Options' dockable does this. This is to be as backwards
    compatible with the old tab style setup, we make 'automatic' the
    default everywhere.
    
    We have quite a bit of dependency to internal layout code in
    GtkNotebook, but the current code should be pixel perfect and rather
    complete.
    
    Also add a basic regression test.

and then:

commit 6812d5bdceb05263ca6068f3084b25b37e40323c
Author: Martin Nordholts <martinn@src.gnome.org>
Date:   Wed May 26 18:10:31 2010 +0200

    Bug 346881 - Remove redundant title of tab and move menu button up
    
    Remove the dockable drag handle and move the menu button it hosts up
    to the GimpDockbook, with the gtk_notebook_set_action_widget() API.
    
    This frees up quite a lot of screen estate which can be used for the
    content of dockables instead.

It should be pretty stable and pixel-perfect by now, but I'll leave this bug report open for a while longer so we have a place to iron out the last things.
Comment 9 Martin Nordholts 2010-06-11 23:23:32 UTC
Review of attachment 152905 [details] [review]:

Commited.
Comment 10 Martin Nordholts 2010-06-18 18:59:20 UTC
There have been some final polishing and fixes by now, closing as FIXED.