GNOME Bugzilla – Bug 346438
Error dialog too wide (URI needs to be truncated)
Last modified: 2010-09-14 04:25:25 UTC
Steps to reproduce the bug : 1. subscribe to a bugzilla iCalendar as a remote calendar 2. try to access the calendar from behind a proxy or when you have no network 3. look at this superb 3 to 6 screen long dialog Expected behavior : The URI should be splited or shortened to fit in the screen so the user do not have to painfully move the window with the mouse or use the keyboard. One could say it is NOTA but if you use a tablet PC and let your keyboard home, you really feel it's a bug :)
Any user provided data should be checked for "sanity", always. This holds true for URIs, too. (Whatever "sanity" may mean, in this case it sure means that long URIs are adjusted before being displayed raw.) Gilles, I agree. Severity minor, rather than an enhancement (cause it really can be an issue). Not confirming though, since didn't reprocude it yet.
Note: The same fix should be done for any component that potentially displays the raw URI as provided (Calendar, etc). Adjusting Summary.
Any tips on how the URI should be shortened ? Maybe displaying something like http://host/.../endofaddress as a clickable button that would launch gnome-browser and a little tooltip with the full URL wrapped to 80 chars would do it. Comments, toughts ?
another case where this problem arise (in height this time) is when you went to send a signed/crypted message and the "trust keys in my keyring" option is not set (what is this option all about anyway).
Created attachment 158593 [details] [review] The patch suggests displaying the calendar name and group instead uri for the source of error The error dialog was going beyond screen because there was no spacing in uri and that was considered as a word for gtk dialog box. Thus changed the code for displaying the name and group of calendar which is the source of error.
Review of attachment 158593 [details] [review]: Looks good. Patch needs to be committed after the master is open for evolution 3.0 commits.
Comment on attachment 158593 [details] [review] The patch suggests displaying the calendar name and group instead uri for the source of error Committed to master. http://git.gnome.org/browse/evolution/commit/?id=4074ffa416ce27a1e3e85ec049a149d8323093c1