After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346412 - Import images with existing description,
Import images with existing description,
Status: RESOLVED DUPLICATE of bug 337805
Product: f-spot
Classification: Other
Component: Metadata
CVS
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-02 19:17 UTC by Lluís Pàmies
Modified: 2006-07-03 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lluís Pàmies 2006-07-02 19:17:04 UTC
Hello all !

This is my first patch to f-spot, so excuse me if is not correct.

The patch lets you to use the previous image comment as a F-Spot description. This is a new feature that I request some months ago, and I decided that it could be done by myself.

Here the cvs diff output:

Index: src/FileImportBackend.cs
===================================================================
RCS file: /cvs/gnome/f-spot/src/FileImportBackend.cs,v
retrieving revision 1.35
diff -r1.35 FileImportBackend.cs
207a208,211
>                       // Set the existing file description
>                       // FIXME Maybe we can do that in Photo's constructor ...
>                       photo.ReadMetadataFromImage();
>
Index: src/PhotoStore.cs
===================================================================
RCS file: /cvs/gnome/f-spot/src/PhotoStore.cs,v
retrieving revision 1.95
diff -r1.95 PhotoStore.cs
522a523,533
>
>       public void ReadMetadataFromImage ()
>       {
>               FSpot.ImageFile img = FSpot.ImageFile.Create (DefaultVersionUri);
>               if (img is FSpot.JpegFile) {
>                       FSpot.JpegFile jimg = img as FSpot.JpegFile;
>                       description = jimg.Description;
>
>               } else if (img is FSpot.Png.PngFile) {
>                       FSpot.Png.PngFile png = img as FSpot.Png.PngFile;
>                       description = png.Description;
523a535,537
>               }
>       }
>

Thanks to all for f-spot !
Comment 1 Stephane Delcroix 2006-07-03 08:54:42 UTC
(In reply to comment #0)

> This is a new feature that I request some months ago, and I decided that it
> could be done by myself.

Do you remember the bug # of you feature request ?
Comment 2 Bengt Thuree 2006-07-03 11:16:41 UTC
This is included in the patch to read embedded XMP tags in bug #342137
Comment 3 Lluís Pàmies 2006-07-03 14:04:36 UTC
This feature was requested in: #337805
Comment 4 Stephane Delcroix 2006-07-03 14:12:47 UTC

*** This bug has been marked as a duplicate of 337805 ***