After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346331 - There is no Undo button
There is no Undo button
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: Editing
0.1.x
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
: 373318 576961 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-01 04:10 UTC by Gabriel Hurley
Modified: 2018-07-01 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gabriel Hurley 2006-07-01 04:10:58 UTC
People often make mistakes when editing photos, yet f-spot does not include an undo button; all changes are final. This is not usable.

Other information:
Comment 1 Bengt Thuree 2006-07-01 04:33:31 UTC
True, there is no undo button.
But all changes are stored in a new version. Is this enough or?
Comment 2 Stephane Delcroix 2006-07-01 08:04:18 UTC
the only un-doable action is 'delete from drive'. what about internally move the deleted items to trash ?
Comment 3 Bengt Thuree 2006-07-01 08:30:39 UTC
Actually, you can do the following and run into problem if you regret...

Pick a photo
crop it --> new version
Change to color a bit --> NO new version, same as crop version
Remove Red Eye --> NO new version, same as crop version.

You only get a new version when you start from original version.

Check bug #331263 for more information
Comment 4 Gabriel Hurley 2006-07-01 17:08:27 UTC
But it would be so much easier if there was just one undo button that undid the last action, regardless of what type of action it is.
Comment 5 Gabriel Burt 2007-01-17 05:55:22 UTC
*** Bug 373318 has been marked as a duplicate of this bug. ***
Comment 6 Jason Switzer 2007-02-18 17:24:13 UTC
This is a must-have feature. I think a key concept behind versioning the images is to undo something that you have done by mistake.

The only way to achieve the same concept of undo in f-spot is to create a separate version for EVERY change made. This is cumbersome at best. A simple undo would be more logical and useful.
Comment 7 rdwtux 2007-02-21 17:06:31 UTC
Definately need an undo option.  The file versioning method is not intuitive at all.  Also there doesn't seem to be a key-combo in order to delete the current version.  Currently after any testing or changes to the image, the user needs to go through the menu, select delete version and then try a change again. 

CTRL-z should be available so image changes can be quickly undone.
Comment 8 Dominik Possner 2009-01-07 23:08:43 UTC
http://brainstorm.ubuntu.com/item/17012/

Idea #17012: Ctrl + Z should work in F-Spot too. 
Comment 9 Maxxer 2009-03-27 14:04:06 UTC
*** Bug 576961 has been marked as a duplicate of this bug. ***
Comment 10 Ned 2009-08-11 13:30:38 UTC
I select a photo and change the mode to 'Edit Image'.

I crop the image in a carefully-proportioned rectangle around the people in the photo.

I use the Sepia Tone effect. Then I use the Desaturate effect. I don't like this last change, so I press the Sepia Tone button again. Unfortunately, this just makes the image worse and I can't seem to undo anything.

Soon, I discover I can use the combobox to revert back to the original photo. It means I have to carefully crop again, and now I am more wary about playing with effects. I don't want to, but each time I try something I don't like, I have to redo all my work.

Today, I watched someone new to f-spot trying to modify an image they planned to upload into Facebook. I watched them go through a similar process, ending in teeth-clenching and irritation.

For several years this bug has had no real activity. Could a developer at least mark this as 'Confirmed', thanks :P
Comment 11 Ruben Vermeersch 2009-08-11 13:39:17 UTC
Certainly confirmed. Even better, I'm working on repeatable editing, which will allow you to go back and change your color adjustment parameters. It's still very early, it doesn't support adjusting crops yet, but for repeated color adjustments (the desaturate, sepia and adjust color tools), it works great. I'll probably blog about this later this week.

There won't be an undo button just yet, but it will finally be implementable, adding undo will be a matter of saving snapshots of adjustment parameters and going back and forward between them. Repeatable editing is needed to get there.
Comment 12 Nicolò Chieffo 2009-11-25 09:30:44 UTC
Thanks for taking care of this. Is there any news?
Comment 13 André Klapper 2018-07-01 09:02:56 UTC
f-spot is not under active development anymore, has not seen code changes for five years, and saw its last tarball release in the year 2010.
Its codebase has been archived: https://gitlab.gnome.org/Archive/f-spot/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.