After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345295 - [PATCH] gstreamer/libs/gst/net for Windows
[PATCH] gstreamer/libs/gst/net for Windows
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal enhancement
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Reported: 2006-06-19 10:12 UTC by Joni Valtanen
Modified: 2006-09-05 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

gstreamer winnet (60.00 KB, application/x-tar)
2006-06-19 10:13 UTC, Joni Valtanen
patch (15.84 KB, patch)
2006-06-20 14:10 UTC, Joni Valtanen
none Details | Review
Support for Windows (10.31 KB, patch)
2006-09-01 12:28 UTC, Joni Valtanen
committed Details | Review

Description Joni Valtanen 2006-06-19 10:12:23 UTC
Package gstreamer libs/get/net doesn't compile with windows

-added nessessary Windows network stuff
-replaced unix sockets with pipe.
-close(netsocket) replaced with closesocket()
-added inet_aton function
-tried to make it work with minimal modification to original

There is needed testing. Only test was to get farsight compile and transfer audio with that.

It has own directory and can easily added to gstreamer/libs/gst/ dir for testing.
Comment 1 Joni Valtanen 2006-06-19 10:13:44 UTC
Created attachment 67613 [details]
gstreamer winnet
Comment 2 Wim Taymans 2006-06-19 14:17:50 UTC
as said on IRC, needs to be a complete patch with proper #ifdef etc..
Comment 3 Joni Valtanen 2006-06-20 14:10:51 UTC
Created attachment 67712 [details] [review]

i think this is the patch.
Comment 4 Joni Valtanen 2006-06-21 11:14:14 UTC
(In reply to comment #3)
> Created an attachment (id=67712) [edit]
> patch
> i think this is the patch.

This is not the right patch. Wrong place. Sorry. 
Comment 5 Tim-Philipp Müller 2006-07-17 08:11:44 UTC
Do you have the right patch somewhere then? :)
Comment 6 Joni Valtanen 2006-07-17 11:02:03 UTC
(In reply to comment #5)
> Do you have the right patch somewhere then? :)

No. Sorry. 

I have had holiday and have no time to make anything. Try to make it asap.
Comment 7 Joni Valtanen 2006-09-01 12:28:18 UTC
Created attachment 72018 [details] [review]
Support for Windows

Not sure about CYGWIN support. Is cygwin recognized like G_OS_WIN32 with glib. Code is not tested, just cross-compiled with MinGW.
Comment 8 Wim Taymans 2006-09-05 08:35:44 UTC
        * libs/gst/net/gstnetclientclock.c: (inet_aton),
        (gst_net_client_clock_init), (gst_net_client_clock_finalize),
        (gst_net_client_clock_do_select), (gst_net_client_clock_new):
        * libs/gst/net/gstnetclientclock.h:
        * libs/gst/net/gstnettimepacket.c: (gst_net_time_packet_send):
        * libs/gst/net/gstnettimepacket.h:
        * libs/gst/net/gstnettimeprovider.c: (inet_aton),
        (gst_net_time_provider_init), (gst_net_time_provider_finalize),
        (gst_net_time_provider_thread), (gst_net_time_provider_new):
        * libs/gst/net/gstnettimeprovider.h:
        Make stuff compile on windows. Fixes #345295.