After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344599 - doesn't build due to unquoted VERSION
doesn't build due to unquoted VERSION
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 343186 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-11 18:18 UTC by Frederic Peters
Modified: 2006-06-18 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Frederic Peters 2006-06-11 18:18:49 UTC 
Hello, as seen on http://jhbuild.bxlug.be/builds/2006-06-11-0015/logs/totem/#build

 $ grep VERSION config.h
#define PACKAGE_VERSION "1.5.1"
#define VERSION 1.5.1

I don't know if VERSION should be fixed to be quoted or if src/totem.c should reference PACKAGE_VERSION instead of VERSION so I don't provide the trivial patches.

(this is due to a newer autoconf version, 2.59.cvs.2006.05.25-1)
Comment 1 Bastien Nocera 2006-06-12 09:46:36 UTC 
2006-06-12  Bastien Nocera  <hadess@hadess.net>

        * data/playlist.glade:
        * data/properties.glade:
        * data/screenshot.glade:
        * data/skip_to.glade:
        * data/totem.glade:
        Remove mentions of media-player-48.png, so that we use
        the themed icon
        * src/totem-mozilla-viewer.c: (on_about1_activate):
        * src/totem.c: (on_about1_activate), (main):
        * src/vanity.c: (on_about1_activate), (main):
        use PACKAGE_VERSION instead of VERSION, as PACKAGE_VERSION is meant
        to be a string, unlike VERSION, spotted by Frederic Peters
        (Closes: #344599)
Comment 2 Bastien Nocera 2006-06-18 21:31:14 UTC 
*** Bug 343186 has been marked as a duplicate of this bug. ***