After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344364 - Alt+Left/Right reorders tabs if not swallowed by Gecko
Alt+Left/Right reorders tabs if not swallowed by Gecko
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
2.15.x
Other Linux
: Normal normal
: 2.16.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 395165 (view as bug list)
Depends on:
Blocks: 350342
 
 
Reported: 2006-06-09 05:12 UTC by Ed Catmur
Modified: 2007-01-12 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
344364.bugzilla.gnome.org-intercept-alt-left-right.patch (1.03 KB, patch)
2006-06-09 06:03 UTC, Ed Catmur 		none Details | Review
344364.bugzilla.gnome.org-intercept-alt-left-right.patch (1.21 KB, patch)
2006-06-09 06:21 UTC, Ed Catmur 		accepted-commit_after_freeze Details | Review

Description Ed Catmur 2006-06-09 05:12:02 UTC 
epiphany 2.15.2
gtk+ 2.9.2
gecko from firefox 1.5.0.4

When I hit Alt+Left (back), if the page is already at the beginning of the tab history, the tab bar is reordered, the current tab moving to the left. The same happens with Alt+Right.

This is surprising and (no doubt) non-higgy.

I guess Gecko is (sensibly) failing to swallow the keysym and it's getting interpreted by GtkNotebook.
Comment 1 Ed Catmur 2006-06-09 06:03:20 UTC 
Created attachment 67018 [details] [review]
344364.bugzilla.gnome.org-intercept-alt-left-right.patch

Block keystroke if not swallowed by Gecko.
Comment 2 Ed Catmur 2006-06-09 06:21:55 UTC 
Created attachment 67019 [details] [review]
344364.bugzilla.gnome.org-intercept-alt-left-right.patch

I really should get into the habit of testing patches *before* submitting them...
Comment 3 Christian Persch 2006-06-09 12:11:53 UTC 
I cannot reproduce this... do you have Alt-Left/Right assigned to move tabs menu items in the Tabs menu?
Comment 4 Ed Catmur 2006-06-12 12:27:23 UTC 
No, I have Shift+Ctrl+Page Up/Down (the usual, I think).

Strange that you can't reproduce it - are you sure you're running gtk+ 2.9.2 (or later CVS)?
Comment 5 Christian Persch 2006-06-12 13:22:00 UTC 
Weird, I can reproduce now, maybe I tried the wrong epiphany.

So this appears to be by design in gtk 2.9 gtknotebook:

  gtk_binding_entry_add_signal (binding_set, keysym, GDK_MOD1_MASK,
                                "reorder_tab", 2,
                                GTK_TYPE_DIRECTION_TYPE, direction,
                                G_TYPE_BOOLEAN, move_to_last);
  gtk_binding_entry_add_signal (binding_set, keypad_keysym, GDK_MOD1_MASK,
                                "reorder_tab", 2,
                                GTK_TYPE_DIRECTION_TYPE, direction,
                                G_TYPE_BOOLEAN, move_to_last);


But I think this ought to use Ctrl-PgUp/Down instead. That would conflict with some textview bindings in gedit however... still, Alt-Left/Right is just wrong.

CCing some gtk+ devs for opinions.
Comment 6 Christian Persch 2006-09-03 12:52:15 UTC 
Looks good, until bug 350342 is resolved.

Please add a comment pointing to the bug reports when committing this.
Commit to gnome-2-16 and HEAD.
Comment 7 Christian Persch 2006-12-02 17:54:27 UTC 
Seem this is obsolete now that gtk bug 350342 is fixed?
Comment 8 Ed Catmur 2006-12-17 12:37:41 UTC 
Yup, guess so.
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2007-01-10 21:29:47 UTC 
*** Bug 395165 has been marked as a duplicate of this bug. ***
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2007-01-10 21:29:59 UTC 
Nope it isn't, still happens here :).
Comment 11 Carlos Garnacho 2007-01-10 22:05:09 UTC 
Note that it was fixed in GTK 2.10.7 and trunk, do you have any of these? In fact, I've just noticed that it's now gecko which is invasive to GTK, when focus is in a notebook tab (or any widget) the keybinding moves through history (GTK trunk and ephy 2.17.4 here)
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2007-01-11 12:55:16 UTC 
Hmmm, so the problem mutated? :/.

Now I'm confused, is this still valid or not?
Comment 13 Carlos Garnacho 2007-01-11 13:53:35 UTC 
not really, Gecko seems to swallow all the events it handles, regardless of whether it has the focus or not, it's just more noticeable now that it shares a keybinding with a widget in ephy GUI...
Comment 14 Christian Persch 2007-01-11 20:52:17 UTC 
Alt-Left/Right moving through history is managed _by Epiphany_, not gecko.
Comment 15 Carlos Garnacho 2007-01-12 00:34:13 UTC 
Ah :), then the summary is wrong. Totally unimportant for the issue I mentioned. Perhaps should be moved to a new bug, and this one get closed?
Comment 16 Christian Persch 2007-01-12 00:56:19 UTC 
Yes, please.
Comment 17 Carlos Garnacho 2007-01-12 01:53:01 UTC 
I've just opened bug #395652 :)