GNOME Bugzilla – Bug 344361
Need to be able to select new photo repository from the command line
Last modified: 2006-09-14 13:56:08 UTC
I want to be able to have several collections of photos that are accessed separately. The main use case is to have a collection of photos on my laptop hard drive, and another collection of photos on an external hard drive, and to be able to select which collection f-spot shows on the command line. Each collection should be completely independant, and should contain it's own imported photos and database.
Closely related to bug 325166
Created attachment 67013 [details] [review] add --photoDir argument to select a directory for photos adds a --photoDir argument that allows the user to select a directory to contain both the database file and the imported photos. also adds a --baseDir argument that allows the user to select just the location of the database file.
How about related to bug #331953 Regarding related to bug #325166, this one is abount importing photos to user configurable location. The current bug is about using different Photos and photos.db like, one set for work and one set for private.
This seems like it could be more usefully implemented by having two GConf keys for these locations. Then people who want to change it can (via the cmd line or gconf-editor) do it now and we leave the option open to having that as an exposed preference in the prefs dialog at some point. Also, then you don't have to specify that argument each time you run. Only downside is if you have multiple photo DBs or directories it would be a little more annoying to switch between them...
The whole point is that I *do* have multiple photo DBs --- and need to switch between them easily. I really don't want to have to edit gconf everytime I switch... it's also really slick for testing, since you can maintain multiple photo dirs with different configurations and load up an appropriate one to test the features you are trying to test...
Gabriel: Check bug #337250 – Option to rename "Photos" directory and how it is organized (which is part of Goal #3). This one stores everything in gconf.
Created attachment 71085 [details] [review] An updated version containing also the fix for bug #325166 this one is an integration of patch #67013 and patch #71072. you can set --photodir and --basedir separately, you can also change the default via the preference dialog.
Created attachment 71234 [details] [review] updated version. contains also the fix for bug #325166 Applied the 2 changes from the latest version of the fix for bug #325166 i.e. : - small fix in the dialog - creates Photos localized
Created attachment 71297 [details] [review] updated version UI fix from bug #325166 This patch contains also the latest version of the one proposed to bug #325166
This patch is small and very usefull. Applies cleanly to latest HEAD, and compiles cleanly. Works without a problem. I only have a nitpicky thing. If you run f-spot --help you get the following printout --view <file> view a file or directory --basedir <dir> <dir> where the photo database is located --photodir <file> import photos in <dir> --shutdown shutdown a running f-spot server Also, why not store the basedir (photos.db path) in preferences?
Created attachment 71468 [details] [review] updated version fixed the identation thing We agreed on the mailing list to not giving the user a way to change the basedir via the preference dialog. My opinion is if it's not changeable, there's no reason to have it in gconf. Having it fixed (like now) will prevent the user to loose/erase their db. I don't want to give any chance to 'average joe' to start playing with it and then giving a bad press to f-spot. We can't afford this.
Couple comments: 1) We use import directory everywhere else. Probably should change to --importdir for consistency (and clarity). 2) When I run /home/bmon/mylocal/bin/f-spot --basedir /home/bmon/.gnome2/f-spot.cvs/ --photodir /tmp/FSPOT And I open the preference dialog, the import dir combo is disabled and contains 'src' (without quotes). Locking the import dialog may be what we want since it was passed in, but it would be nice to show the actual import dir. I just tried creating the directory, and now it shows FSPOT as it should so it looks like an issue only when the directory doesn't already exist. Other than that it looks good and should save tons of time for those who need to maintain multiple dbs.
This one do not apply cleanly anymore, but it is only a trivial change to preferences.cs that fails. Also, the f-spot --help gives the following which should be changed: --photodir <file> import photos in <dir> should be --photodir <dir> import photos in <dir>
Change status to ready for commit. Should modify the help text according to above comment though.
Larry committed this in CVS