After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344163 - srcdir != builddir breaks stock icon cache
srcdir != builddir breaks stock icon cache
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: Other
2.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 414139
 
 
Reported: 2006-06-07 15:01 UTC by Frederic Crozat
Modified: 2014-08-03 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Frederic Crozat 2006-06-07 15:01:13 UTC 
current tarball of gtk+ 2.9.2 is shipping with a generated copy of gtkbuiltincache.h, which is causing problem when building with srcdir != builddir. In this case, up to date gtkbuiltincache.h is correctly generated in builddir but the copy in srcdir is used for compilation, resulting in missing stock icons.

Bad hack is to remove gtkbuiltincache.h from srcdir and everything works fine.

I think this file should not be shipped in tarball but after reading Makefile.am, it seems wanted by GTK+ maintainers. Any reason for this ?
Comment 1 Matthias Clasen 2006-06-07 15:32:19 UTC 
it should be shipped, so that it doesn't have to be regenerated every time...
Comment 2 Frederic Crozat 2006-06-07 16:01:18 UTC 
It wouldn't be regenerated everytime, only for the first build for the untarred tree.

And with srcdir != builddir, it is generated in builddir :(

Anyway, if shipping generated file is wanted, there is another problem with make dist, since the generated file in tarball was incorrect :

-rw-r--r-- 3877/3877     36453 2006-06-05 19:25 gtk+-2.9.2/gtk/gtkbuiltincache.h

correct size is 2389227.
Comment 3 Federico Mena Quintero 2006-06-07 16:57:49 UTC 
This happens in a clean build from CVS, not just from tarballs, and even when builddir == srcdir.

Also, should gtkbuiltincache.h really be in the tarball?  The correct version is 2.3 MB...
Comment 4 Matthias Clasen 2006-06-08 00:10:08 UTC 
It compresses really well, though, a gzipped version is ~150k.

Also, not shipping it simply moves the "correct generation" problem
we see from dist time to build time, meaning that a lot more people
will face it, as opposed to just the one person doing the release.
Comment 5 Matthias Clasen 2006-06-09 12:54:26 UTC 
Is this fixed with Juergbi's change ?
Comment 6 Matthias Clasen 2014-08-03 15:08:07 UTC 
We no longer use a builtin icon cache