After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343973 - libsoup's xmlrpc fault handling is broken
libsoup's xmlrpc fault handling is broken
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
2.2.x
Other Linux
: High normal
: ---
Assigned To: Dan Winship
Dan Winship
Depends on:
Blocks: 133765
 
 
Reported: 2006-06-06 03:42 UTC by Brent Smith (smitten)
Modified: 2006-06-07 19:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
untested patch (it compiles) (1.49 KB, patch)
2006-06-06 03:45 UTC, Brent Smith (smitten) 		none Details | Review

Description Brent Smith (smitten) 2006-06-06 03:42:18 UTC 
From what I can see there is a member in the SoupXmlrpcResponsePrivate structure for the fault to be set, but this is never actually assigned in the function soup_xmlrpc_response_from_string().  Also, there is no public method to check to see if a fault has occurred.  Since the soup_xmlrpc_response_from_string() function points the "value" member regardless of whether the response returned <params> or <fault>, we need a way to determine if there was a fault.

untested patch follows.
Comment 1 Brent Smith (smitten) 2006-06-06 03:45:14 UTC 
Created attachment 66806 [details] [review]
untested patch (it compiles)

Does three things.

1) Assigns the "fault" member of the SoupXmlrpcResponsePriv structure to the local variable's value in soup_xmlrpc_response_from_string()
2) Provide a public function to access the priv->value member called soup_xmlrpc_response_is_fault()
3) Provide a prototype for the new function in soup-xmlrpc-response.h
Comment 2 Olav Vitters 2006-06-07 16:01:13 UTC 
This patch is needed for Bug-Buddy XML-RPC bug submission. We want to include the XML-RPC Bug-Buddy in 2.15.3 (12th). Appreciate if this could be added + new libsoup be released.
Comment 3 Dan Winship 2006-06-07 19:45:19 UTC 
Committed. I'll probably wait until Monday to put out the new release, in case any other bugfixes come in between now and then.