After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343686 - itip-view.c:format_date_and_time_x() should use e_utf8_strftime_fix_am_pm()
itip-view.c:format_date_and_time_x() should use e_utf8_strftime_fix_am_pm()
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.6.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 314124 (view as bug list)
Depends on:
Blocks: 336253
 
 
Reported: 2006-06-02 11:52 UTC by Tor Lillqvist
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (19.80 KB, image/png)
2006-08-29 14:11 UTC, André Klapper 		  Details
patch. thanks to tor! :-) (1.34 KB, patch)
2006-08-29 14:12 UTC, André Klapper 		committed Details | Review

Description Tor Lillqvist 2006-06-02 11:52:52 UTC 
itip-view.c:format_date_and_time_x() should use e_utf8_strftime_fix_am_pm() and not e_utf8_strftime(). Otherwise times in messages in the Calendar folded will show up in 12h format even in 24h locales, which is confusing as hell, as you don't get any AM/PM indicator anyway. At least that's what happened for me, and simply changing it to call e_utf8_strftime_fix_am_pm() instead worked fine. (Once I figured out that the date and time in question is produced in a plugin, of all places...)
Comment 1 André Klapper 2006-08-29 14:11:41 UTC 
Created attachment 71831 [details]
screenshot

see the wrong time displayed (i added the correct time as the description of the appointment)
Comment 2 André Klapper 2006-08-29 14:12:32 UTC 
Created attachment 71832 [details] [review]
patch. thanks to tor! :-)

fixes the issue, i tested this.
Comment 3 Chenthill P 2006-09-14 09:42:58 UTC 
Please commit the patch to cvs HEAD and gnome-2-14 branches. 

andre, also if poss., please verify if this problem exists in the calendar views as well. As i see e_utf8_strftime is used in many parts of the code. There are some checks made to ensure the usage of the 24 hour format for the locales which do not provide AM/PM information using calendar_config_get_24_hour_format (this internally checks the condition and returns appropriate value).

Tor, thats really a good catch !!!

thanks tor and andre.
Comment 4 André Klapper 2006-09-14 16:42:41 UTC 
patch committed to cvs head and gnome-2-14 branch.

chen, i haven't seen any other cases here in my german environment yet, i'm inclined to close this.
Comment 5 André Klapper 2006-09-27 10:38:48 UTC 
*** Bug 314124 has been marked as a duplicate of this bug. ***